Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TUG Etapas checkpoint 1st round of trials #357

Merged
merged 16 commits into from
Apr 6, 2023

Conversation

fbrand-new
Copy link
Contributor

Hi,

This PR contains all the changes that were effective during the first rounds of trials on 4/4/2023.

Notably

  • Added offline data analysis with TUG phases automatic detection.
  • Application is now manually launched. Docker compose used to set up yarprun servers.
  • Skeleton duplication issues fixed.
  • Out of bounds check is added.
  • Various small fixes.

Copy link
Member

@pattacini pattacini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @fbrand-new

Nice job with the tests!

I was the maintainer of this repo, but as discussed F2f w/ @randaz81 I'm no longer going to deal with this duty although I've remained particularly fond of the skeleton library plus the skeletonRetriever and the skeletonViewer module, given my authorship. Thus, I'll continue to maintain these components and I can also give help with them, of course.

Thereby, would you mind cleaning up the code to remove the debug lines and the leftovers. You may keep them by yourself in a dedicated branch or fork. Thanks in advance!

I've also dropped an inline comment about the gaze frame.

modules/skeletonRetriever/src/main.cpp Outdated Show resolved Hide resolved
@fbrand-new
Copy link
Contributor Author

Hi @pattacini, thanks for the comments! Sure, I will make sure to clean up as much as I can the mess that has been left around (sorry for that).

@pattacini
Copy link
Member

pattacini commented Apr 6, 2023

Hi @pattacini, thanks for the comments! Sure, I will make sure to clean up as much as I can the mess that has been left around (sorry for that).

Never mind, no problem @fbrand-new!
I meant just to clean up skeletonRetriever, whose changes can be fully reverted, judging from the PR.

Copy link
Member

@pattacini pattacini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks heaps @fbrand-new 👍🏻

@pattacini pattacini merged commit 572e598 into robotology:master Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants