Allow writing CBO bits in xenvcfg #635
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results396 tests ±0 0 ✅ - 396 0s ⏱️ ±0s For more details on these failures, see this check. Results for commit 05fd1f9. ± Comparison against base commit 5f4a8e6. ♻️ This comment has been updated with latest results. |
|
Shouldn't these be gated on |
|
Ah yes you're right. I'll update it. |
This was accidentally missed from the CBO implementation.
|
I'll wait for #634 since this is exactly the sort of problem it helps with. |
Timmmm
force-pushed
the
user/timh/cbo_menvcfg
branch
from
6f6b126 to
05fd1f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was accidentally missed from the CBO implementation.