-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/add featured widget #2390
Fix/add featured widget #2390
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@@ -49,8 +49,9 @@ export class W3mConnectView extends LitElement { | |||
<w3m-connect-recent-widget></w3m-connect-recent-widget> | |||
<w3m-connect-announced-widget></w3m-connect-announced-widget> | |||
<w3m-connect-injected-widget></w3m-connect-injected-widget> | |||
<w3m-connect-coinbase-widget></w3m-connect-coinbase-widget> | |||
<w3m-connect-featured-widget></w3m-connect-featured-widget> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@svenvoskamp What about the w3m-connect-coinbase-widget
one? Does the featured widgets including coinbase as well? If yes, should we remove w3m-connect-coinbase-widget
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tomiir @enesozturk I think coinbase is part of w3m-connect-external-widget
? Please correct me if I'm wrong.
I think we can remove the w3m-connect-coinbase-widget
and replace it for the external one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the only external one we have is coinbase. We can remove either of them I think, but CB widget has some logic to hide the duplicated connectors
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, then I will remove the external one
…b3modal into fix/add-featured-widget
…b3modal into fix/add-featured-widget
Changes
closes #2383