Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/add featured widget #2390

Closed
wants to merge 20 commits into from
Closed

Fix/add featured widget #2390

wants to merge 20 commits into from

Conversation

svenvoskamp
Copy link
Contributor

Changes

  • fix: add featured widget

closes #2383

Copy link

vercel bot commented Jun 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
web3modal-gallery ✅ Ready (Inspect) Visit Preview Jun 12, 2024 9:18am
web3modal-laboratory ✅ Ready (Inspect) Visit Preview Jun 12, 2024 9:18am

@@ -49,8 +49,9 @@ export class W3mConnectView extends LitElement {
<w3m-connect-recent-widget></w3m-connect-recent-widget>
<w3m-connect-announced-widget></w3m-connect-announced-widget>
<w3m-connect-injected-widget></w3m-connect-injected-widget>
<w3m-connect-coinbase-widget></w3m-connect-coinbase-widget>
<w3m-connect-featured-widget></w3m-connect-featured-widget>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@svenvoskamp What about the w3m-connect-coinbase-widget one? Does the featured widgets including coinbase as well? If yes, should we remove w3m-connect-coinbase-widget?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tomiir @enesozturk I think coinbase is part of w3m-connect-external-widget? Please correct me if I'm wrong.

I think we can remove the w3m-connect-coinbase-widget and replace it for the external one

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the only external one we have is coinbase. We can remove either of them I think, but CB widget has some logic to hide the duplicated connectors

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, then I will remove the external one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] featuredWalletIds option is broken, starting from v4.2.2
3 participants