refactor: coinbase connector popup improvements #2392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…b3modal into fix/add-featured-widget
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
enesozturk
requested review from
tomiir and
svenvoskamp
and removed request for
tomiir
tomiir
reviewed
Jun 11, 2024
packages/scaffold/src/partials/w3m-connect-external-widget/index.ts
Outdated
Show resolved
Hide resolved
tomiir
approved these changes
Jun 12, 2024
…b3modal into fix/add-featured-widget
svenvoskamp
reviewed
Jun 12, 2024
packages/scaffold/src/partials/w3m-connect-external-widget/index.ts
Outdated
Show resolved
Hide resolved
enesozturk
force-pushed
the
refactor/coinbase-connector-popup-trigger-logic
branch
from
808c00d
to
492ff66
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
onConnecttrigger logicWhen users select a connector, we are redirecting them to
w3m-connecting-external-viewand trigger theonConnectmethod in the first render and watch changes. While this is working fine 99%, there are some issues with the ones which opens a popup.Coinbase's new SDK using popups and modern browsers disable popups if they are triggered programmatically rather than user action. If a user not trigger the popup, they are being disabled. This results to not have popup opened on some browsers/devices. I.e Safari/iOS.
iOS Safari app have
Block pop-upssetting enabled by default underSettings > Safari > General. Most users don't aware of this and the ones who select Coinbase won't be realizing there should be popup opened.Fix
To fix this, we need to trigger the connection once the users select the Coinbase app from the wallet list, and at the same time, redirect them to loading page (
w3m-connecting-external-view) and watch changes.This PR introduces changes to connector methods to handle this specific case for Coinbase.