Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/add featured widget #2390

Closed
wants to merge 20 commits into from
Closed

Fix/add featured widget #2390

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
ae6407f
Merge branch 'V4' of github.com:WalletConnect/web3modal into V4
svenvoskamp May 15, 2024
9888c89
Merge branch 'V4' of github.com:WalletConnect/web3modal into V4
svenvoskamp May 15, 2024
4362254
Merge branch 'V4' of github.com:WalletConnect/web3modal into V4
svenvoskamp May 16, 2024
fa858a4
Merge branch 'V4' of github.com:WalletConnect/web3modal into V4
svenvoskamp May 16, 2024
2920ef4
Merge branch 'V4' of github.com:WalletConnect/web3modal into V4
svenvoskamp May 27, 2024
e7fc41b
Merge branch 'V4' of github.com:WalletConnect/web3modal into V4
svenvoskamp Jun 3, 2024
c7ed29e
Merge branch 'V4' of github.com:WalletConnect/web3modal into V4
svenvoskamp Jun 5, 2024
987d806
Merge branch 'V4' of github.com:WalletConnect/web3modal into V4
svenvoskamp Jun 10, 2024
d010311
Merge branch 'V4' of github.com:WalletConnect/web3modal into V4
svenvoskamp Jun 11, 2024
b3a5f94
Merge branch 'V4' of github.com:WalletConnect/web3modal into V4
svenvoskamp Jun 11, 2024
5efd2b3
add featured widget
svenvoskamp Jun 11, 2024
1dc70f9
Merge branch 'V4' into fix/add-featured-widget
svenvoskamp Jun 11, 2024
d0dd49d
Merge branch 'V4' into fix/add-featured-widget
svenvoskamp Jun 11, 2024
bad9b9a
add external and remove coinbase
svenvoskamp Jun 11, 2024
70e47f0
Merge branch 'fix/add-featured-widget' of github.com:WalletConnect/we…
svenvoskamp Jun 11, 2024
c9a388b
Merge branch 'V4' into fix/add-featured-widget
svenvoskamp Jun 12, 2024
213df1e
remove external widget
svenvoskamp Jun 12, 2024
4c158b4
Merge branch 'fix/add-featured-widget' of github.com:WalletConnect/we…
svenvoskamp Jun 12, 2024
8df037a
merge
svenvoskamp Jun 12, 2024
7a28dc2
Merge branch 'V4' into fix/add-featured-widget
svenvoskamp Jun 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/scaffold/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,6 @@ export * from './src/partials/w3m-wallet-login-list/index.js'
export * from './src/partials/w3m-social-login-list/index.js'
export * from './src/partials/w3m-connect-announced-widget/index.js'
export * from './src/partials/w3m-connect-custom-widget/index.js'
export * from './src/partials/w3m-connect-external-widget/index.js'
export * from './src/partials/w3m-connect-featured-widget/index.js'
export * from './src/partials/w3m-connect-injected-widget/index.js'
export * from './src/partials/w3m-connect-coinbase-widget/index.js'
Expand Down
59 changes: 0 additions & 59 deletions packages/scaffold/src/partials/w3m-connect-external-widget/index.ts
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion packages/scaffold/src/partials/w3m-wallet-login-list/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@ export class W3mWalletLoginList extends LitElement {
<w3m-connect-injected-widget></w3m-connect-injected-widget>
<w3m-connect-featured-widget></w3m-connect-featured-widget>
<w3m-connect-custom-widget></w3m-connect-custom-widget>
<w3m-connect-coinbase-widget></w3m-connect-coinbase-widget>
<w3m-connect-recommended-widget></w3m-connect-recommended-widget>
<w3m-connect-external-widget></w3m-connect-external-widget>
<w3m-all-wallets-widget></w3m-all-wallets-widget>
</wui-flex>
`
Expand Down
3 changes: 2 additions & 1 deletion packages/scaffold/src/views/w3m-connect-view/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,9 @@ export class W3mConnectView extends LitElement {
<w3m-connect-recent-widget></w3m-connect-recent-widget>
<w3m-connect-announced-widget></w3m-connect-announced-widget>
<w3m-connect-injected-widget></w3m-connect-injected-widget>
<w3m-connect-coinbase-widget></w3m-connect-coinbase-widget>
<w3m-connect-featured-widget></w3m-connect-featured-widget>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@svenvoskamp What about the w3m-connect-coinbase-widget one? Does the featured widgets including coinbase as well? If yes, should we remove w3m-connect-coinbase-widget?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tomiir @enesozturk I think coinbase is part of w3m-connect-external-widget? Please correct me if I'm wrong.

I think we can remove the w3m-connect-coinbase-widget and replace it for the external one

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the only external one we have is coinbase. We can remove either of them I think, but CB widget has some logic to hide the duplicated connectors

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, then I will remove the external one

<w3m-connect-custom-widget></w3m-connect-custom-widget>
<w3m-connect-coinbase-widget></w3m-connect-coinbase-widget>
<w3m-connect-recommended-widget></w3m-connect-recommended-widget>
<wui-flex class="all-wallets" .margin=${['xs', '0', '0', '0'] as const}>
<w3m-all-wallets-widget></w3m-all-wallets-widget>
Expand Down
Loading