-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FENCE-2186 add countryCodes as param for search places #430
Merged
KennyHuRadar
merged 6 commits into
master
from
kennyhu/fence-2186-add-country-support-to-sdks-for-native-ios
Jan 27, 2025
Merged
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
66ab55c
add countryCodes as param for search places
KennyHuRadar 515bfd9
update tests
KennyHuRadar 3ff578d
add migration docs
KennyHuRadar c484298
add link
KennyHuRadar 67f59ff
add link
KennyHuRadar 4a58e3f
Merge branch 'master' into kennyhu/fence-2186-add-country-support-to-…
KennyHuRadar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
Pod::Spec.new do |s| | ||
s.name = 'RadarSDK' | ||
s.version = '3.20.1' | ||
s.version = '3.21.0' | ||
s.summary = 'iOS SDK for Radar, the leading geofencing and location tracking platform' | ||
s.homepage = 'https://radar.com' | ||
s.author = { 'Radar Labs, Inc.' => '[email protected]' } | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
Pod::Spec.new do |s| | ||
s.name = 'RadarSDKMotion' | ||
s.version = '3.20.1' | ||
s.version = '3.21.0' | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Need to bump this |
||
s.summary = 'Motion detection plugin for RadarSDK, the leading geofencing and location tracking platform' | ||
s.homepage = 'https://radar.com' | ||
s.author = { 'Radar Labs, Inc.' => '[email protected]' } | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -898,6 +898,7 @@ - (void)test_Radar_searchPlaces_errorPermissions { | |
chains:@[@"walmart"] | ||
categories:nil | ||
groups:nil | ||
countryCodes:nil | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Would be nice to have this with multiple countries. |
||
limit:100 | ||
completionHandler:^(RadarStatus status, CLLocation *_Nullable location, NSArray<RadarPlace *> *_Nullable places) { | ||
XCTAssertEqual(status, RadarStatusErrorPermissions); | ||
|
@@ -923,6 +924,7 @@ - (void)test_Radar_searchPlaces_errorLocation { | |
chains:@[@"walmart"] | ||
categories:nil | ||
groups:nil | ||
countryCodes:nil | ||
limit:100 | ||
completionHandler:^(RadarStatus status, CLLocation *_Nullable location, NSArray<RadarPlace *> *_Nullable places) { | ||
XCTAssertEqual(status, RadarStatusErrorLocation); | ||
|
@@ -954,6 +956,7 @@ - (void)test_Radar_searchPlaces_chains_success { | |
chains:@[@"walmart"] | ||
categories:nil | ||
groups:nil | ||
countryCodes:nil | ||
limit:100 | ||
completionHandler:^(RadarStatus status, CLLocation *_Nullable location, NSArray<RadarPlace *> *_Nullable places) { | ||
XCTAssertEqual(status, RadarStatusSuccess); | ||
|
@@ -988,6 +991,7 @@ - (void)test_Radar_searchPlaces_chainsAndMetadata_success { | |
chainMetadata:@{@"orderActive": @"true"} | ||
categories:nil | ||
groups:nil | ||
countryCodes:nil | ||
limit:100 | ||
completionHandler:^(RadarStatus status, CLLocation *_Nullable location, NSArray<RadarPlace *> *_Nullable places) { | ||
XCTAssertEqual(status, RadarStatusSuccess); | ||
|
@@ -1025,6 +1029,7 @@ - (void)test_Radar_searchPlacesNear_categories_success { | |
chains:nil | ||
categories:@[@"restaurant"] | ||
groups:nil | ||
countryCodes:nil | ||
limit:100 | ||
completionHandler:^(RadarStatus status, CLLocation *_Nullable location, NSArray<RadarPlace *> *_Nullable places) { | ||
XCTAssertEqual(status, RadarStatusSuccess); | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be nice to have this tested with multiple countries.