-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FENCE-2186 add countryCodes as param for search places #430
Changes from all commits
66ab55c
515bfd9
3ff578d
c484298
67f59ff
4a58e3f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,8 @@ | ||
# Migration guides | ||
|
||
## 3.20.x to 3.21.x | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This will need a bump. |
||
- The `Radar.searchPlaces()` method now expects an additional parameter `countryCodes` to filter results by country. See [documentation](https://radar.com/documentation/sdk/ios#search). | ||
|
||
## 3.12.x to 3.13.x | ||
- The `Radar.trackVerified()` method now returns `token: RadarVerifiedLocationToken`, which includes `user`, `events`, `token,`, `expiresAt`, `expiresIn`, and `passed`. The `Radar.trackVerifiedToken()` method has been removed, since `Radar.trackVerified()` now returns a signed JWT. | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
Pod::Spec.new do |s| | ||
s.name = 'RadarSDK' | ||
s.version = '3.20.2' | ||
s.version = '3.21.0' | ||
s.summary = 'iOS SDK for Radar, the leading geofencing and location tracking platform' | ||
s.homepage = 'https://radar.com' | ||
s.author = { 'Radar Labs, Inc.' => '[email protected]' } | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
Pod::Spec.new do |s| | ||
s.name = 'RadarSDKMotion' | ||
s.version = '3.20.2' | ||
s.version = '3.21.0' | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Need to bump this |
||
s.summary = 'Motion detection plugin for RadarSDK, the leading geofencing and location tracking platform' | ||
s.homepage = 'https://radar.com' | ||
s.author = { 'Radar Labs, Inc.' => '[email protected]' } | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -898,6 +898,7 @@ - (void)test_Radar_searchPlaces_errorPermissions { | |
chains:@[@"walmart"] | ||
categories:nil | ||
groups:nil | ||
countryCodes:nil | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Would be nice to have this with multiple countries. |
||
limit:100 | ||
completionHandler:^(RadarStatus status, CLLocation *_Nullable location, NSArray<RadarPlace *> *_Nullable places) { | ||
XCTAssertEqual(status, RadarStatusErrorPermissions); | ||
|
@@ -923,6 +924,7 @@ - (void)test_Radar_searchPlaces_errorLocation { | |
chains:@[@"walmart"] | ||
categories:nil | ||
groups:nil | ||
countryCodes:nil | ||
limit:100 | ||
completionHandler:^(RadarStatus status, CLLocation *_Nullable location, NSArray<RadarPlace *> *_Nullable places) { | ||
XCTAssertEqual(status, RadarStatusErrorLocation); | ||
|
@@ -954,6 +956,7 @@ - (void)test_Radar_searchPlaces_chains_success { | |
chains:@[@"walmart"] | ||
categories:nil | ||
groups:nil | ||
countryCodes:nil | ||
limit:100 | ||
completionHandler:^(RadarStatus status, CLLocation *_Nullable location, NSArray<RadarPlace *> *_Nullable places) { | ||
XCTAssertEqual(status, RadarStatusSuccess); | ||
|
@@ -988,6 +991,7 @@ - (void)test_Radar_searchPlaces_chainsAndMetadata_success { | |
chainMetadata:@{@"orderActive": @"true"} | ||
categories:nil | ||
groups:nil | ||
countryCodes:nil | ||
limit:100 | ||
completionHandler:^(RadarStatus status, CLLocation *_Nullable location, NSArray<RadarPlace *> *_Nullable places) { | ||
XCTAssertEqual(status, RadarStatusSuccess); | ||
|
@@ -1025,6 +1029,7 @@ - (void)test_Radar_searchPlacesNear_categories_success { | |
chains:nil | ||
categories:@[@"restaurant"] | ||
groups:nil | ||
countryCodes:nil | ||
limit:100 | ||
completionHandler:^(RadarStatus status, CLLocation *_Nullable location, NSArray<RadarPlace *> *_Nullable places) { | ||
XCTAssertEqual(status, RadarStatusSuccess); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be nice to have this tested with multiple countries.