Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FENCE-2186 add countryCodes as param for search places #430

Conversation

KennyHuRadar
Copy link
Contributor

No description provided.

@@ -141,6 +141,7 @@ class AppDelegate: UIResponder, UIApplicationDelegate, UIWindowSceneDelegate, UN
chainMetadata: ["orderActive": "true"],
categories: nil,
groups: nil,
countryCodes: ["US"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to have this tested with multiple countries.

@@ -898,6 +898,7 @@ - (void)test_Radar_searchPlaces_errorPermissions {
chains:@[@"walmart"]
categories:nil
groups:nil
countryCodes:nil
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to have this with multiple countries.

@@ -1,5 +1,8 @@
# Migration guides

## 3.20.x to 3.21.x
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will need a bump.

@@ -1,6 +1,6 @@
Pod::Spec.new do |s|
s.name = 'RadarSDKMotion'
s.version = '3.20.1'
s.version = '3.21.0'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to bump this

@KennyHuRadar KennyHuRadar merged commit 840ec42 into master Jan 27, 2025
2 checks passed
@KennyHuRadar KennyHuRadar deleted the kennyhu/fence-2186-add-country-support-to-sdks-for-native-ios branch January 27, 2025 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants