Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Q score both read directions #72

Merged
merged 24 commits into from
Dec 13, 2024

Conversation

colinvwood
Copy link
Contributor

Addresses #71

@colinvwood colinvwood self-assigned this Dec 9, 2024
@colinvwood colinvwood force-pushed the q-score-both-read-directions branch from ca101ea to 5e589aa Compare December 9, 2024 20:51
@ebolyen ebolyen assigned gregcaporaso and unassigned colinvwood Dec 12, 2024
Copy link
Member

@gregcaporaso gregcaporaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@colinvwood, a handful of little suggestions but overall this looks really good.

q2_quality_filter/_transformer.py Show resolved Hide resolved
.gitignore Show resolved Hide resolved
q2_quality_filter/_filter.py Show resolved Hide resolved
q2_quality_filter/tests/test_filter.py Show resolved Hide resolved
q2_quality_filter/tests/test_filter.py Show resolved Hide resolved
q2_quality_filter/tests/test_filter.py Outdated Show resolved Hide resolved
q2_quality_filter/_filter.py Outdated Show resolved Hide resolved
q2_quality_filter/_filter.py Outdated Show resolved Hide resolved
q2_quality_filter/_filter.py Show resolved Hide resolved
q2_quality_filter/_filter.py Show resolved Hide resolved
Copy link
Member

@gregcaporaso gregcaporaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the edits @colinvwood!

@gregcaporaso gregcaporaso merged commit 5d1e22f into qiime2:dev Dec 13, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Completed
Development

Successfully merging this pull request may close these issues.

q-score should process and return both read directions when paired end reads are inputted
2 participants