Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Float GEMM on PULP with Tiling #26

Merged
merged 1 commit into from
Jan 17, 2025
Merged

Add Float GEMM on PULP with Tiling #26

merged 1 commit into from
Jan 17, 2025

Conversation

runwangdl
Copy link
Contributor

@runwangdl runwangdl commented Jan 17, 2025 •
edited by Victor-Jung
Loading

This PR focuses on the implementation of FP GEMM and GEMM tiling on the PULP platform, demonstrating that the development of floating-point operators with tiling on the PULP platform is now fully functional.

Added

  • pulpfpGEMM binding with tiler and constraint support
  • floatGEMM test in CI Siracusa

Changed

  • deployTest.c now supports float inputs and outputs.
  • testMVP default input datatype changed from int64 to float64.

PR Merge Checklist

  1. The PR is rebased on the latest devel commit and pointing to devel.
  2. Your PR reviewed and approved.
  3. All checks are passing.
  4. The CHANGELOG.md file has been updated.

@Victor-Jung Victor-Jung self-requested a review January 17, 2025 14:41
Victor-Jung
Victor-Jung reviewed Jan 17, 2025
View reviewed changes
Copy link
Member

@Victor-Jung Victor-Jung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Another good PR :) After addressing my comment about the number of tiles in the test we should be able to merge.

.github/workflows/CI.yml Outdated Show resolved Hide resolved
@runwangdl
Add Float GEMM on PULP with Tiling
aa88bd1 
1. add pulpfpgemm binding, tiler, connstraint
2. add floatgemm test to CI Siracusa
3. change deeploytest for float input & output
4. change testMVP input default datatype from int64 to float64
@Victor-Jung Victor-Jung merged commit 7344dab into pulp-platform:devel Jan 17, 2025
106 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Victor-Jung Victor-Jung Victor-Jung approved these changes

Assignees

@runwangdl runwangdl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@runwangdl @Victor-Jung