Skip to content
This repository has been archived by the owner on Jul 5, 2024. It is now read-only.

[proof chunk] WIP: rw_table witness commitment to derive challenge #1709

Conversation

hero78119
Copy link
Member

@hero78119 hero78119 commented Dec 14, 2023

Contents

  • introduce get_rwtable_cols_commitment which will be used to get rw_table column witnesses commitment
  • [temporarily] hardcode challenge value in aggregation circuit and remove hardcode later

Other notes

Need to upgrade PSE-halo2 api empty_lagrange_assigned visibility to public.

Design rationale

Implement commitment follow halo2 create_proof to collect witness and commit

@github-actions github-actions bot added the crate-zkevm-circuits Issues related to the zkevm-circuits workspace member label Dec 14, 2023
@hero78119 hero78119 marked this pull request as draft December 14, 2023 07:48
@hero78119 hero78119 force-pushed the rwtable_comitment branch 2 times, most recently from 7cd97b5 to fd6a65a Compare December 14, 2023 13:11
@hero78119
Copy link
Member Author

Hi @CeciliaZ030 this PR introduce new api get_rwtable_cols_commitment so we can derive unblinded advice column commitment in the same way to compute permutation challenge in bus-mapping, FYI

@CeciliaZ030
Copy link
Contributor

I wonder if there's an easier way to do this other than instantiating a new circuit in get_rwtable_cols_commitment, for example changing the existing Challenge API to squeeze challenge from specified unblinded_advice_column during the assignment phase? In that way the whole design will change 😅 but one solution could be uniting the Challenge and UserChallenge to one big thing?
I don't know I'm just brainstorming.

@hero78119
Copy link
Member Author

Covered in PR #1773

@hero78119 hero78119 closed this Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
crate-zkevm-circuits Issues related to the zkevm-circuits workspace member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants