[proof-chunk] Instantiate circuits with Chunk from bus-mapping

[CeciliaZ030]

Description

Instantiate circuits with Block and specified Chunk from bus-mapping. Refactor CircuitInputBuilder to generate given number of Chunks with fixed or dynamic params. Note that one instance of the circuit corresponds to one chunk instead of one block.

Issue Link

#1696

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

Contents

• Initialize the CircuitInputBuilder with either FixedCParam or just specify the total number of chunk and dynamically derive parameter after a dry run.
• In handle_tx split the chunk whenever the local rwc exceeds the target amount, specifically by setting the EndChunk and proceed to the next BeginChunk if needed.
• Commit the ChunkCtx for each chunk at the end, which tracks the global Rw range & local rwc later used in the State circuits.
• After the block is handled, generate witness for a specific chunk with builder.chunk_convert(idx), analogous to builder.block_convert().
• Config the circuit with both block and chunk, which leads to API changes in SubCircuit<F: Field> trait including new_from_block(&block, &chunk) and min_num_rows_block(&block, &chunk).

Workflow

For CircuitInputBuilder chunk is needed to build all circuits:

let builder = BlockData::new_from_geth_data(geth_data.clone())
        .new_circuit_input_builder()
        .handle_block(&eth_block, &geth_traces)
        .expect("handle_block");
    
let block = block_convert(&builder);   
let chunk = chunk_convert(&builder, 0);
   
let circuit = SuperCircuit::new_from_block(&block, &chunk);

For CircuitTestBuilder modifier is applied to both block and chunk, and you can run with fixed or dynamic params:

CircuitTestBuilder::new_from_test_ctx(
        TestContext::<2, 1>::simple_ctx_with_bytecode(bytecode).unwrap(),
    )
    .modifier(Box::new(move |block, chunk| {
        // do something..
    }))
    .run_dynamic_chunk(4, 2);

CircuitTestBuilder::new_from_block(block)
    .params(FixedCParams {
        total_chunks: 2,
        max_rws: 60,
        ..Default::default()
    })
    .run_chunk(1);

Default run() still works since it runs one chunk internally.

CircuitTestBuilder::new_from_block(block).run()

[hero78119]

Thanks for the PR!
First round quick passed and just few feedbacks

• it will be more clear to have PR description for what items has been covered in this PR along with TODO items.
• By quick overview I think current scope of PR is
  • define chunk structure in bus-mapping
  • convert chunk structure to chunk witness and bypass to circuit
    I think current chunk structure might need to be further tuning when chunking flow are introduced, which seems to be in downstream work by @einar-taiko ? May I know whats plan to combining both works ?

[CeciliaZ030]

Latest chunked scope

Red: directly chunked data are Rw -> state_circuit and ExecStep -> evm_circuit

• Chunked Vec<Rw> are kept in struct Chunk<F>
• Txs & Steps are chunked in execution.rs, see below:

let chunk_txs = block.txs.get(chunk.initial_tx - 1..chunk.end_tx)
let chunk_steps = chunk_txs.iter().map(|tx| tx.steps()).collect()

Blue: chunking CopyEvent cause by lookup into state table: copy_circuit.rs
Green: using chunked Transaction from evm_circuit for configuring tuples of (Tx, Call, Step), but tx_circuit is not affected.

[hero78119]

Thanks for the contribution @CeciliaZ030 ⭐
Will merge it first and leave other improvement to future PR