chores: adjust domain api visibility #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hero78119
changed the title
kilic
approved these changes
Dec 15, 2023
CPerezz
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Recently in zkEVM proof chunk we introduce
user-challengeto derive application level challenge by random oracle with selected columns commitments. To derive commitment of advices column, we follow halo2 create_proof api, where one of the halo2 domain api need to adjust visibility to public, since this is the only way to derivePolynomial<Assigned<F>, LagrangeCoeff>type.Furthermore, another domain api
fn empty_lagrangeis also public so it make sense forfn empty_lagrange_assignedas well.reference usecase zkEVM PR privacy-scaling-explorations/zkevm-circuits#1709