-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add buttons example and module #58
base: master
Are you sure you want to change the base?
Conversation
obj.buttonHandler = {}; | ||
|
||
obj.onPress = function onPress(type, callback) { | ||
this.buttonHandler[type] = callback; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ignore everything except Up, Down, Left, and Right
The file You hit the error because |
@HBehrens this should be ready to review now that I've removed the API from symbols-manual.js and created a module instead. |
I don't think we need the three |
}; | ||
|
||
(function() { | ||
onPress("back", function() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you put this logic into an anonymous function to not pollute the global namespace but currentText
as well as rocky
are still globals.
@HBehrens Ready for you to take another look. |
Added Buttons example folder
Added Buttons to examples readme.md
Added module folder containing buttons.js
Please let me know if you think the readme on the buttons example is a bit light.