Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: extract op-reth binary to separate crate #10641

Merged
merged 43 commits into from
Sep 2, 2024
Merged

refactor: extract op-reth binary to separate crate #10641

Show file tree
Hide file tree
Changes from 42 commits
Commits
Show all changes
43 commits
Select commit Hold shift + click to select a range
afb7643
moved opt bin and cli runner to optimism-cli
loocapro Jul 11, 2024
e3052d1
added cargo bin sections
loocapro Jul 11, 2024
d83bc31
added optimism bin crate
loocapro Jul 11, 2024
b5c707a
bin features
loocapro Jul 11, 2024
08bd2b2
removed crate
loocapro Jul 11, 2024
c9c5c4e
chore: fix cli runner docs
loocapro Jul 11, 2024
5083d63
review
loocapro Jul 11, 2024
6d9b427
reth optimism cli feature
loocapro Jul 11, 2024
d2ea7c5
removing optimism flags from reth bin and op specific commands
loocapro Jul 12, 2024
649c3b4
removed cfg flag on block_excutor
loocapro Jul 12, 2024
39f8de1
removing optimism crates and cfg from reth bin
loocapro Jul 12, 2024
5f1e37c
removing top level cfg optimism
loocapro Jul 12, 2024
25d6e82
removing opt feature from cargo.toml
loocapro Jul 12, 2024
d4004ec
still removing cfg flags
loocapro Jul 12, 2024
9ec5af1
removed flag to calculate_receipt_root_opt
loocapro Jul 12, 2024
bad053b
enabling optimism feature for reth-primitives
loocapro Jul 12, 2024
dbe771d
removed block executor macro
loocapro Jul 12, 2024
963f41d
rebase
loocapro Jul 18, 2024
5a5abeb
merge origin/main
joshieDo Jul 29, 2024
3fa37f7
Revert "merge origin/main"
joshieDo Jul 29, 2024
ae52a20
Merge remote-tracking branch 'origin/main' into move-optimism-bin
joshieDo Jul 29, 2024
1169896
rm optimism flag from crates/optimism
joshieDo Jul 29, 2024
bf735a3
node-optimism does not have feature flag anymore
joshieDo Jul 29, 2024
9ddebb0
rm optimism feature from node e2e
joshieDo Jul 29, 2024
8e44890
Revert "rm optimsm feature from node e2e"
joshieDo Jul 29, 2024
9e441cd
Revert "node-optimism does not have feature flag anymore"
joshieDo Jul 29, 2024
80a2a0c
Revert "rm optimism flag from crates/optimism"
joshieDo Jul 29, 2024
92048f9
add optimism flags to optimism/bin
joshieDo Jul 29, 2024
c826ca7
force optimism feature on op crates
joshieDo Jul 29, 2024
ecf534f
rm op-reth doctest
joshieDo Jul 29, 2024
14512dd
fix test compilation
joshieDo Jul 29, 2024
88d7506
add asm-keccak to op-reth
joshieDo Jul 29, 2024
93a10d8
add manifest path on Makefile for op builds
joshieDo Jul 29, 2024
c526109
exclude reth-optimism-bin from hack check
joshieDo Jul 29, 2024
05f7420
exclude op-reth from hack check
joshieDo Jul 29, 2024
4630840
update op-sync ci
joshieDo Jul 29, 2024
565d9d7
add test ci
joshieDo Jul 29, 2024
8e40c3c
rm tmp ci test
joshieDo Jul 29, 2024
809d198
Merge remote-tracking branch 'origin/main' into move-optimism-bin
joshieDo Jul 29, 2024
0e9aedb
Merge branch 'main' into klkvr/extract-optimism-cli
klkvr Aug 31, 2024
29b77db
fixes
klkvr Aug 31, 2024
2b7adcc
rename to op-reth
klkvr Aug 31, 2024
ab626d5
add step to crate-checks
klkvr Sep 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ jobs:
- uses: Swatinem/rust-cache@v2
with:
cache-on-failure: true
- run: cargo hack check
- run: cargo hack check --workspace --exclude op-reth
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

think you will have to add a new job for op-reth, we still want to check lint for op code

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added a step to run cargo check on it with optimism feature


msrv:
name: MSRV / ${{ matrix.network }}
Expand Down
3 changes: 1 addition & 2 deletions .github/workflows/op-sync.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,7 @@ jobs:
with:
cache-on-failure: true
- name: Build op-reth
run: |
cargo install --features asm-keccak,jemalloc,optimism --bin op-reth --path bin/reth
run: make install-op
- name: Run sync
# https://basescan.org/block/10000
run: |
Expand Down
Loading
Loading