-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: extract op-reth
binary to separate crate
#10641
Merged
Merged
Changes from all commits
Commits
Show all changes
43 commits
Select commit
Hold shift + click to select a range
afb7643
moved opt bin and cli runner to optimism-cli
loocapro e3052d1
added cargo bin sections
loocapro d83bc31
added optimism bin crate
loocapro b5c707a
bin features
loocapro 08bd2b2
removed crate
loocapro c9c5c4e
chore: fix cli runner docs
loocapro 5083d63
review
loocapro 6d9b427
reth optimism cli feature
loocapro d2ea7c5
removing optimism flags from reth bin and op specific commands
loocapro 649c3b4
removed cfg flag on block_excutor
loocapro 39f8de1
removing optimism crates and cfg from reth bin
loocapro 5f1e37c
removing top level cfg optimism
loocapro 25d6e82
removing opt feature from cargo.toml
loocapro d4004ec
still removing cfg flags
loocapro 9ec5af1
removed flag to calculate_receipt_root_opt
loocapro bad053b
enabling optimism feature for reth-primitives
loocapro dbe771d
removed block executor macro
loocapro 963f41d
rebase
loocapro 5a5abeb
merge origin/main
joshieDo 3fa37f7
Revert "merge origin/main"
joshieDo ae52a20
Merge remote-tracking branch 'origin/main' into move-optimism-bin
joshieDo 1169896
rm optimism flag from crates/optimism
joshieDo bf735a3
node-optimism does not have feature flag anymore
joshieDo 9ddebb0
rm optimism feature from node e2e
joshieDo 8e44890
Revert "rm optimsm feature from node e2e"
joshieDo 9e441cd
Revert "node-optimism does not have feature flag anymore"
joshieDo 80a2a0c
Revert "rm optimism flag from crates/optimism"
joshieDo 92048f9
add optimism flags to optimism/bin
joshieDo c826ca7
force optimism feature on op crates
joshieDo ecf534f
rm op-reth doctest
joshieDo 14512dd
fix test compilation
joshieDo 88d7506
add asm-keccak to op-reth
joshieDo 93a10d8
add manifest path on Makefile for op builds
joshieDo c526109
exclude reth-optimism-bin from hack check
joshieDo 05f7420
exclude op-reth from hack check
joshieDo 4630840
update op-sync ci
joshieDo 565d9d7
add test ci
joshieDo 8e40c3c
rm tmp ci test
joshieDo 809d198
Merge remote-tracking branch 'origin/main' into move-optimism-bin
joshieDo 0e9aedb
Merge branch 'main' into klkvr/extract-optimism-cli
klkvr 29b77db
fixes
klkvr 2b7adcc
rename to op-reth
klkvr ab626d5
add step to crate-checks
klkvr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
think you will have to add a new job for op-reth, we still want to check lint for op code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added a step to run
cargo check
on it with optimism feature