Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: extract op-reth binary to separate crate #10641

Merged
merged 43 commits into from
Sep 2, 2024

Conversation

klkvr
Copy link
Collaborator

@klkvr klkvr commented Aug 31, 2024

ref #9439

I've changed OpChainSpecParser to return an inner ChainSpec for now to avoid introducing more complex bounds on cli types. We can change it back once we figure out how the bounds should look like on underlying types

Copy link
Member

@emhane emhane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job

@emhane
Copy link
Member

emhane commented Sep 1, 2024

do mind trying to fix the commit history on this branch? usually does it by checking out a backup branch of your diff from main, then on this branch git reset --hard main, then cherry pick from backup branch

@klkvr
Copy link
Collaborator Author

klkvr commented Sep 1, 2024

do mind trying to fix the commit history on this branch? usually does it by checking out a backup branch of your diff from main, then on this branch git reset --hard main, then cherry pick from backup branch

you mean squashing the diff into less number of commits without merge commits?

@joshieDo
Copy link
Collaborator

joshieDo commented Sep 1, 2024

no need to touch up the history of the branch imo, this all gets squashed into main anyway

emhane
emhane previously requested changes Sep 2, 2024
Copy link
Member

@emhane emhane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as long as the diff in 'Files changed' isn't showing unrelated changes, and other people are comfortable reviewing (@joshieDo), then I'm fine with unrelated changes showing in GitHub commit history for the pr

@@ -71,7 +71,7 @@ jobs:
- uses: Swatinem/rust-cache@v2
with:
cache-on-failure: true
- run: cargo hack check
- run: cargo hack check --workspace --exclude op-reth
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

think you will have to add a new job for op-reth, we still want to check lint for op code

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added a step to run cargo check on it with optimism feature

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hell yeah, let's try this again hehe

@mattsse mattsse added this pull request to the merge queue Sep 2, 2024
Merged via the queue into main with commit fcab695 Sep 2, 2024
37 checks passed
@mattsse mattsse deleted the klkvr/extract-optimism-cli branch September 2, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants