Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fine-tuned scGPT #17

Merged
merged 14 commits into from
Jan 17, 2025
Merged

Add fine-tuned scGPT #17

merged 14 commits into from
Jan 17, 2025

Conversation

lazappi
Copy link
Contributor

@lazappi lazappi commented Dec 10, 2024 •
edited
Loading

Describe your changes

Add a fine-tuned version of the scGPT foundation model as a method.

Checklist before requesting a review

  • I have performed a self-review of my code

  • Check the correct box. Does this PR contain:

    • Breaking changes
    • New functionality
    • Major changes
    • Minor changes
    • Bug fixes

  • Proposed changes are described in the CHANGELOG.md

  • CI Tests succeed and look good!

@lazappi lazappi requested a review from rcannood December 10, 2024 10:04
@lazappi
Copy link
Contributor Author

lazappi commented Dec 10, 2024

This will probably have conflicts with #16 so that should probably be merged first

@lazappi
Merge remote-tracking branch 'origin/main' into feature/no-ref/add-sc…
381605d 
…GPT-finetuned

* origin/main:
  Add argument to give model path to scGPT (#16)
@lazappi
Add model arguments to scgpt_finetuned
7e845e7 
Fixed some things in scgpt_zeroshot...
rcannood
rcannood approved these changes Jan 13, 2025
View reviewed changes
Copy link
Member

@rcannood rcannood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lazappi
Copy link
Contributor Author

lazappi commented Jan 13, 2025

Do you want to exclude it in the run_full_*.sh scripts? At the moment it's only excluded from the local runs.

@rcannood
Copy link
Member

Do you want to exclude it in the run_full_*.sh scripts? At the moment it's only excluded from the local runs.

Oh i see -- yes please! At least for now

@lazappi
Exclude scgpt_finetuned from full benchmark runs
cd171cd 
Need to sort out GPU infrastructure
@lazappi
Copy link
Contributor Author

lazappi commented Jan 14, 2025

Oh i see -- yes please! At least for now

Done

@lazappi
Merge remote-tracking branch 'origin/main' into feature/no-ref/add-sc…
ad07a22 
…GPT-finetuned

* origin/main:
  Pin scPRINT version (#25)
  Increase UCE memory tag (#24)
  Add exit codes helper file (#26)
  Include all features in solution (#28)
  Update common submodule (#29)
@rcannood rcannood merged commit 6191552 into main Jan 17, 2025
3 checks passed
@rcannood rcannood deleted the feature/no-ref/add-scGPT-finetuned branch January 17, 2025 07:38
lazappi added a commit that referenced this pull request Jan 17, 2025
@lazappi
Merge remote-tracking branch 'origin/main' into bugfix/no-ref/adjust-…
b3b584e 
…resources

* origin/main:
  Add batch_hvg var column to solution (#31)
  Add fine-tuned scGPT (#17)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rcannood rcannood rcannood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lazappi @rcannood