feat: make course -> lib import synchronous #34030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorhaugh
commented
Jan 9, 2024
| # TODO: This task is synchronous until we can figure out race conditions with import | ||
| # These race conditions lead to failed imports of library content from course import. | ||
| # See: TNL-TNL-11339, https://github.com/openedx/edx-platform/issues/34029 for more info. | ||
| library_tasks.sync_from_library.apply( |
There was a problem hiding this comment.
https://docs.celeryq.dev/en/latest/reference/celery.app.task.html is how you know apply is the method to use.
kdmccormick
approved these changes
Jan 9, 2024
Co-authored-by: Kyle McCormick <[email protected]>
connorhaugh
deleted the
2u/connorhaugh/feat-make-lib-upgrade-synchronous
branch
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
|
2U Release Notice: This PR has been deployed to the edX production environment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On an openedx platform with async workers enabled,
If a course author uploads a course which references some library that exists already on the platform, they run into errors.
This is because xml_importer makes an async call to spawn the import of the content from the library
And then it proceeds to attempt to copy & publish the library content block's children, which leads to the likely state where the celery task has not copied in the LCB's new children, and this means that the publish cannot see the children, and fails.
In order to fix this, I am making the call to sync_from_library an
applycall, not adelaycall, so that it operates synchronously until we figure out a long-term solution.Supporting information
https://2u-internal.atlassian.net/browse/TNL-11339
#34029