Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Library Sync conflicts with imports. #34029

Closed
connorhaugh opened this issue Jan 9, 2024 · 1 comment
Closed

Library Sync conflicts with imports. #34029

connorhaugh opened this issue Jan 9, 2024 · 1 comment
Labels
content libraries misc Libraries Overhaul tech work not captured in the stories

Comments

@connorhaugh
Copy link
Contributor

On an openedx platform with async workers enabled,

If a course author uploads a course which references some library that exists already on the platform, they run into errors.

This is because xml_importer makes an async call to spawn the import of the content from the library

And then it proceeds to attempt to copy & publish the library content block's children, which leads to the likely state where the celery task has not copied in the LCB's new children, and this means that the publish cannot see the children, and fails.

In order to fix this, I am making the call to sync_from_library an apply call, not a delay call, so that it operates synchronously until we figure this out.

@kdmccormick
Copy link
Member

Seems like #34030 fixed the immediate issue.

I think it makes sense to keep this synchronous, since we need the content to be copied from the library before the course can be published. If this causes issues, then we can look into making publish and copy-from-library asynchronous, with publish blocking on the completion of copy-from-library.

@kdmccormick kdmccormick added the content libraries misc Libraries Overhaul tech work not captured in the stories label May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content libraries misc Libraries Overhaul tech work not captured in the stories
Projects
None yet
Development

No branches or pull requests

2 participants