Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make course -> lib import synchronous #34030

Merged
merged 4 commits into from
Jan 9, 2024
Merged

feat: make course -> lib import synchronous #34030

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cbe0923
feat: make course -> lib import synchronous
connorhaugh Jan 9, 2024
ae92126
style: nit
connorhaugh Jan 9, 2024
9011839
fix: kwargs dict
connorhaugh Jan 9, 2024
761cedf
fix: lint nit
connorhaugh Jan 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions xmodule/library_tools.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,10 +128,16 @@ def trigger_library_sync(self, dest_block: LibraryContentBlock, library_version:
if library_version:
raise ObjectDoesNotExist(f"Version {library_version} of library {library_key} not found.")
raise ObjectDoesNotExist(f"Library {library_key} not found.")
library_tasks.sync_from_library.delay(
user_id=self.user_id,
dest_block_id=str(dest_block.scope_ids.usage_id),
library_version=library_version,

# TODO: This task is synchronous until we can figure out race conditions with import.
# These race conditions lead to failed imports of library content from course import.
# See: TNL-11339, https://github.com/openedx/edx-platform/issues/34029 for more info.
library_tasks.sync_from_library.apply(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://docs.celeryq.dev/en/latest/reference/celery.app.task.html is how you know apply is the method to use.

kwargs=dict(
user_id=self.user_id,
dest_block_id=str(dest_block.scope_ids.usage_id),
library_version=library_version,
),
)

def trigger_duplication(self, source_block: LibraryContentBlock, dest_block: LibraryContentBlock) -> None:
Expand Down
Loading