-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [FC-0006] add Verifiable Credentials optional feature #1973
feat: [FC-0006] add Verifiable Credentials optional feature #1973
Conversation
Thanks for the pull request, @wowkalucky! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
4c10edb
to
40eb0c6
Compare
@wowkalucky confirming this should still be in draft? |
53f96ee
to
9cb0612
Compare
@e0d coverage is almost there. Moved for review. |
2e64ed6
to
e711998
Compare
@e0d we increased patch coverage now. Should we proceed to reach the overall project's target value in this PR? |
d0bc443
to
998e5df
Compare
998e5df
to
c8f446c
Compare
Hi @AliAdnanSohail - would you mind taking a look at this and merging if all looks good? Thanks! |
This is in our current sprint so it should be reviewed and hopefully merged within 2 weeks. |
Hi @AliAdnanSohail - I tagged you by mistake, so please disregard - no need to review this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I understand it, the __init__.py
of a Django app should have a default_app_config
defined and point to the Config class defined in the apps.py
(in this case the VerifiableCredentialsConfig
class).
Not sure if this was missed or just being planned for later, but figured I'd add it here in case it was missed.
(I also have a half-baked assumption that since the ready
function isn't defined as part of the VerifiableCredentialsConfig
class, we might not be able to add a declaration for the default_app_config
yet)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(I also see that there is a larger part 2 OSPR I wasn't immediately aware of, we could probably address that there)
@wowkalucky 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Note: for the sake of review effort simplification, it is decided to split this large PR onto 2 parts:
This is the part 1/2 of the Verifiable Credentials feature.
Related PRs:
Run JavaScript tests locally with Karma
There is work being done on a fix to get Karma to run in CI. Until then, however, contributors are required to run these tests locally.
make test-karma
TODO