Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [FC-0006] add Verifiable Credentials optional feature #1973

Conversation

wowkalucky
Copy link
Contributor

@wowkalucky wowkalucky commented Mar 27, 2023

Note: for the sake of review effort simplification, it is decided to split this large PR onto 2 parts:

  • initial part - introduces a feature flag with a new application modules structure
  • main part - adds all the implementation logic

This is the part 1/2 of the Verifiable Credentials feature.

Related PRs:


Run JavaScript tests locally with Karma

There is work being done on a fix to get Karma to run in CI. Until then, however, contributors are required to run these tests locally.

  • Make sure you are inside the devstack container
  • Run make test-karma
  • All tests pass

TODO

  • - add related Open edX Credentials PR link.
  • - update test coverage

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Mar 27, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented Mar 27, 2023

Thanks for the pull request, @wowkalucky! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@e0d
Copy link

e0d commented Apr 14, 2023

@wowkalucky confirming this should still be in draft?

@wowkalucky wowkalucky force-pushed the dcc/oex-creds-696/verifiable-credentials branch 2 times, most recently from 53f96ee to 9cb0612 Compare April 19, 2023 14:32
@wowkalucky
Copy link
Contributor Author

@e0d coverage is almost there. Moved for review.
The Verifiable Credentials documentation is a matter of a separate PR.

@wowkalucky wowkalucky marked this pull request as ready for review April 19, 2023 16:26
@wowkalucky wowkalucky force-pushed the dcc/oex-creds-696/verifiable-credentials branch 6 times, most recently from 2e64ed6 to e711998 Compare April 25, 2023 15:08
@wowkalucky
Copy link
Contributor Author

@e0d we increased patch coverage now. Should we proceed to reach the overall project's target value in this PR?

@wowkalucky wowkalucky force-pushed the dcc/oex-creds-696/verifiable-credentials branch from 998e5df to c8f446c Compare May 10, 2023 15:09
@wowkalucky wowkalucky marked this pull request as ready for review May 10, 2023 15:12
@mphilbrick211
Copy link

Hi @AliAdnanSohail - would you mind taking a look at this and merging if all looks good? Thanks!

@hurtstotouchfire
Copy link
Member

This is in our current sprint so it should be reviewed and hopefully merged within 2 weeks.

@mphilbrick211 mphilbrick211 removed the request for review from AliAdnanSohail May 22, 2023 17:04
@mphilbrick211 mphilbrick211 requested a review from a team May 22, 2023 17:04
@justinhynes justinhynes self-assigned this May 22, 2023
@mphilbrick211
Copy link

Hi @AliAdnanSohail - would you mind taking a look at this and merging if all looks good? Thanks!

Hi @AliAdnanSohail - I tagged you by mistake, so please disregard - no need to review this PR.

Copy link
Contributor

@justinhynes justinhynes May 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I understand it, the __init__.py of a Django app should have a default_app_config defined and point to the Config class defined in the apps.py (in this case the VerifiableCredentialsConfig class).

Not sure if this was missed or just being planned for later, but figured I'd add it here in case it was missed.

(I also have a half-baked assumption that since the ready function isn't defined as part of the VerifiableCredentialsConfig class, we might not be able to add a declaration for the default_app_config yet)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I also see that there is a larger part 2 OSPR I wasn't immediately aware of, we could probably address that there)

@justinhynes justinhynes merged commit 2d9d73e into openedx:master May 23, 2023
@openedx-webhooks
Copy link

@wowkalucky 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

GlugovGrGlib pushed a commit to raccoongang/credentials that referenced this pull request Aug 1, 2023
@wowkalucky wowkalucky deleted the dcc/oex-creds-696/verifiable-credentials branch November 21, 2023 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Status: Done
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants