Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [FC-0006] add Verifiable Credentials feature #2001

Merged
merged 3 commits into from
Jul 21, 2023
Merged

feat: [FC-0006] add Verifiable Credentials feature #2001

merged 3 commits into from
Jul 21, 2023

Conversation

wowkalucky
Copy link
Contributor

@wowkalucky wowkalucky commented May 8, 2023 •
edited
Loading

Note: for the sake of review effort simplification, it is decided to split this large PR onto 2 parts:

  • initial part - introduces a feature flag with a new application modules structure
  • main part - adds all the implementation logic

This is the part 2/2 of the Verifiable Credentials feature.

Related PRs:

Run JavaScript tests locally with Karma

There is work being done on a fix to get Karma to run in CI. Until then, however, contributors are required to run these tests locally.

  • Make sure you are inside the devstack container
  • Run make test-karma
  • All tests pass

TODO

  • - add related Open edX Credentials PR link.
  • - update test coverage

@openedx-webhooks
Copy link

openedx-webhooks commented May 8, 2023 •
edited
Loading

Thanks for the pull request, @wowkalucky! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label May 8, 2023
@wowkalucky wowkalucky mentioned this pull request May 8, 2023
Merged
5 tasks
@wowkalucky wowkalucky force-pushed the dcc/oex-creds-696/verifiable-credentials-full branch 2 times, most recently from fb96309 to 7bd8660 Compare May 10, 2023 16:59
@wowkalucky wowkalucky marked this pull request as ready for review May 10, 2023 17:07
@wowkalucky wowkalucky marked this pull request as draft June 1, 2023 13:50
GlugovGrGlib
GlugovGrGlib reviewed Jun 9, 2023
View reviewed changes
credentials/apps/verifiable_credentials/issuance/models.py Outdated
@classmethod
def resolve_issuer(cls):
"""
Unconditionally (for now) returns system-level Issier ID.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo in a word Issuer

@wowkalucky wowkalucky force-pushed the dcc/oex-creds-696/verifiable-credentials-full branch from 7bd8660 to 214f0e3 Compare June 26, 2023 11:07
@wowkalucky wowkalucky marked this pull request as ready for review June 26, 2023 12:13
@wowkalucky
Copy link
Contributor Author

@GlugovGrGlib updated for review (coverage check is broken for some reason).

@wowkalucky wowkalucky force-pushed the dcc/oex-creds-696/verifiable-credentials-full branch from ec2741f to a3201a2 Compare July 5, 2023 13:46
GlugovGrGlib
GlugovGrGlib reviewed Jul 20, 2023
View reviewed changes
credentials/apps/verifiable_credentials/signals.py Outdated
issuance_lines = IssuanceLine.objects.filter(user_credential=user_credential)
issuance_lines.update(status=user_credential.status)

# FIXME: invalidate cached status lists
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What actions we should do to remove this FIXME before merging?

@wowkalucky wowkalucky force-pushed the dcc/oex-creds-696/verifiable-credentials-full branch from a0ae907 to fc30f2d Compare July 20, 2023 14:04
@wowkalucky
Copy link
Contributor Author

@GlugovGrGlib rebased to master

@GlugovGrGlib GlugovGrGlib merged commit ccf2e64 into openedx:master Jul 21, 2023
@openedx-webhooks
Copy link

@wowkalucky 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@GlugovGrGlib GlugovGrGlib deleted the dcc/oex-creds-696/verifiable-credentials-full branch July 21, 2023 07:43
GlugovGrGlib added a commit to raccoongang/credentials that referenced this pull request Jul 21, 2023
@GlugovGrGlib
Revert "feat: [FC-0006] add Verifiable Credentials feature (openedx#2001
000ab3c 
)"

This reverts commit ccf2e64.
GlugovGrGlib pushed a commit to raccoongang/credentials that referenced this pull request Aug 1, 2023
@wowkalucky @GlugovGrGlib
feat: [FC-0006] add Verifiable Credentials feature (openedx#2001)
e0c132d 
[FC-0006](https://openedx.atlassian.net/wiki/spaces/COMM/pages/3614900225/FC-0006+-+Credentials+Implementation)

Verifiable Credentials docs: https://edx-credentials.readthedocs.io/en/latest/verifiable_credentials/overview.html
GlugovGrGlib pushed a commit that referenced this pull request Aug 9, 2023
@wowkalucky @GlugovGrGlib
feat: [FC-0006] add Verifiable Credentials feature (#2001)
d5fe5a2 
[FC-0006](https://openedx.atlassian.net/wiki/spaces/COMM/pages/3614900225/FC-0006+-+Credentials+Implementation)

Verifiable Credentials docs: https://edx-credentials.readthedocs.io/en/latest/verifiable_credentials/overview.html
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GlugovGrGlib GlugovGrGlib GlugovGrGlib approved these changes

Assignees
No one assigned
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Aperture-Maintained
Status: Done
Contributions
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wowkalucky @openedx-webhooks @GlugovGrGlib