Skip to content
This repository has been archived by the owner on May 6, 2024. It is now read-only.

[FC-0006] feat: Add settings for Verifiable Credentials #6928

Merged
merged 2 commits into from
May 31, 2023

Conversation

GlugovGrGlib
Copy link
Contributor

This changes allow to configure Verifiable Credentials settings for the "credentials" service.

Related PR:
openedx/credentials#1973

Configuration Pull Request

Make sure that the following steps are done before merging:

  • A SRE team member has approved the PR if it is code shared across multiple services and you don't own all of the services.
  • Are you adding any new default values that need to be overridden when this change goes live? If so:
    • Update the appropriate internal repo (be sure to update for all our environments)
    • If you are updating a secure value rather than an internal one, file a SRE ticket with details.
    • Add an entry to the CHANGELOG.
  • If you are making a complicated change, have you performed the proper testing specified on the Ops Ansible Testing Checklist? Adding a new variable does not require the full list (although testing on a sandbox is a great idea to ensure it links with your downstream code changes).
  • Think about how this change will affect Open edX operators. Have you updated the wiki page for the next Open edX release?

This changes allow to configure Verifiable Credentials settings for the "credentials"
service.

Related tickets:
* [OeX_Cred-426](https://youtrack.raccoongang.com/issue/OeX_Cred-426)
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label May 4, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented May 4, 2023

Thanks for the pull request, @GlugovGrGlib! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@GlugovGrGlib GlugovGrGlib marked this pull request as ready for review May 8, 2023 20:42
@GlugovGrGlib GlugovGrGlib changed the title [DRAFT] [FC-0006] feat: Add settings for Verifiable Credentials [FC-0006] feat: Add settings for Verifiable Credentials May 8, 2023

# TODO: Link to VC documentation
#
# TODO: Comment about adding wallet python module to CREDENTIALS_EXTRA_REQUIREMENTS variable
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could these todos be cleaned up?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, resolved

The link to VC documentation was added. It's 404 as for now only because the documentation PR is still in review openedx/credentials#1991

* feat: [OeX_Cred-790] add comment about verifiable credentials documentation

* docs: remove resolved TODO

---------

Co-authored-by: Glib Glugovskiy <[email protected]>
Copy link
Contributor

@justinhynes justinhynes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this LGTM. I was able to pull these changes into a branch and deploy an internal sandbox with the changes, which I believe still use ansible. The service was deployed and functional. 👍

@e0d
Copy link
Contributor

e0d commented May 23, 2023

@adzuci would you like to merge this or should I?

@e0d e0d merged commit 1d92cb8 into openedx-unsupported:master May 31, 2023
@openedx-webhooks
Copy link

@GlugovGrGlib 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@itsjeyd itsjeyd added the core contributor PR author is a Core Contributor (who may or may not have write access to this repo). label Sep 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants