-
Notifications
You must be signed in to change notification settings - Fork 969
[FC-0006] feat: Add settings for Verifiable Credentials #6928
[FC-0006] feat: Add settings for Verifiable Credentials #6928
Conversation
This changes allow to configure Verifiable Credentials settings for the "credentials" service. Related tickets: * [OeX_Cred-426](https://youtrack.raccoongang.com/issue/OeX_Cred-426)
Thanks for the pull request, @GlugovGrGlib! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
|
||
# TODO: Link to VC documentation | ||
# | ||
# TODO: Comment about adding wallet python module to CREDENTIALS_EXTRA_REQUIREMENTS variable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could these todos be cleaned up?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, resolved
The link to VC documentation was added. It's 404 as for now only because the documentation PR is still in review openedx/credentials#1991
* feat: [OeX_Cred-790] add comment about verifiable credentials documentation * docs: remove resolved TODO --------- Co-authored-by: Glib Glugovskiy <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this LGTM. I was able to pull these changes into a branch and deploy an internal sandbox with the changes, which I believe still use ansible. The service was deployed and functional. 👍
@adzuci would you like to merge this or should I? |
@GlugovGrGlib 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
This changes allow to configure Verifiable Credentials settings for the "credentials" service.
Related PR:
openedx/credentials#1973
Configuration Pull Request
Make sure that the following steps are done before merging: