Chore/update actions

[KevinFabre-ods]

Summary

The goal for this PR is to update version of github actions we used in our CI.
Currently we have warnings about incompatible Node version requirement

Before

After

---

Also

• removed a table Story from Chromatic as the RTL addon we just added doesn't apply on the chromatic snapshot.
• publish Chromatic snapshots only with Node 20

(Internal for Opendatasoft only) Associated Shortcut ticket: 🏴‍☠️

[github-actions]

Coverage after merging chore/update-actions into main will be

94.64%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
src
index.ts	100%	100%	100%	100%
src/client
error.ts	100%	100%	100%	100%
index.ts	84.14%	74.03%	100%	95.31%	102–103, 124, 13, 146, 148, 148–149, 15, 15, 151, 162, 169, 169, 17, 17, 171, 176, 179, 182, 184, 52, 82
types.ts	100%	100%	100%	100%
src/odsql
clauses.ts	82.61%	71.43%	80%	90.91%	14, 32, 42
index.ts	92.05%	83.72%	95.74%	94.19%	111, 146, 25, 28, 56–57, 57, 57–58, 68, 78–79

[github-actions]

Coverage after merging chore/update-actions into main will be

94.64%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
src
index.ts	100%	100%	100%	100%
src/client
error.ts	100%	100%	100%	100%
index.ts	84.14%	74.03%	100%	95.31%	102–103, 124, 13, 146, 148, 148–149, 15, 15, 151, 162, 169, 169, 17, 17, 171, 176, 179, 182, 184, 52, 82
types.ts	100%	100%	100%	100%
src/odsql
clauses.ts	82.61%	71.43%	80%	90.91%	14, 32, 42
index.ts	92.05%	83.72%	95.74%	94.19%	111, 146, 25, 28, 56–57, 57, 57–58, 68, 78–79

[KevinFabre-ods]

@etienneburdet Should we remove the Node matrix for the api-client action?
What the point of having twice (#255 (comment) & #255 (comment)) the coverage message?

[etienneburdet]

LGTM, that was needed indeed!

I'm OK with moving to node 20.x rather than matrix. As for the code coverage, at the very least I would remove the matrix indeed. Why not removing it all together: we're not really using it. Or if we keep it, actually use it accross all the repo and our workflow.

[KevinFabre-ods]

LGTM, that was needed indeed!

I'm OK with moving to node 20.x rather than matrix. As for the code coverage, at the very least I would remove the matrix indeed. Why not removing it all together: we're not really using it. Or if we keep it, actually use it accross all the repo and our workflow.

api-client package is very independent of the two others. Why not keep it, it can help to check that new code has a code coverage. But, it's true that we not are really using it.

Having the same mechanism for the visualization packages can't work.
Code coverage for visualizations-react would means nothing as all logic is in visualizations (unless there is a way to get code coverage of a dependency)

[github-actions]

Coverage after merging chore/update-actions into main will be

94.64%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
src
index.ts	100%	100%	100%	100%
src/client
error.ts	100%	100%	100%	100%
index.ts	84.14%	74.03%	100%	95.31%	102–103, 124, 13, 146, 148, 148–149, 15, 15, 151, 162, 169, 169, 17, 17, 171, 176, 179, 182, 184, 52, 82
types.ts	100%	100%	100%	100%
src/odsql
clauses.ts	82.61%	71.43%	80%	90.91%	14, 32, 42
index.ts	92.05%	83.72%	95.74%	94.19%	111, 146, 25, 28, 56–57, 57, 57–58, 68, 78–79