Skip to content

Commit

Permalink
chore: update github-actions (#255)
Browse files Browse the repository at this point in the history
remove Node matrix and use latest versions for actions
  • Loading branch information
KevinFabre-ods authored Jul 12, 2024
1 parent 8c9f272 commit 2f2b663
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 25 deletions.
19 changes: 7 additions & 12 deletions .github/workflows/api-client.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,22 +8,17 @@ on:
- main
jobs:
build:
name: Get api client test coverage on node ${{ matrix.node }} and ${{ matrix.os }}

runs-on: ${{ matrix.os }}
strategy:
matrix:
node: ["18.x", "20.x"]
os: [ubuntu-latest]
name: Get api client test coverage
runs-on: ubuntu-latest

steps:
- name: Checkout repo
uses: actions/checkout@v2
uses: actions/checkout@v4

- name: Use Node ${{ matrix.node }}
uses: actions/setup-node@v1
- name: Use Node 20
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node }}
node-version: '20.x'

- name: Install
run: npm ci
Expand All @@ -38,7 +33,7 @@ jobs:
working-directory: ./packages/api-client

- name: Comment
uses: romeovs/lcov-reporter-action@v0.2.19
uses: romeovs/lcov-reporter-action@v0.4.0
with:
github-token: ${{ secrets.GITHUB_TOKEN }}
lcov-file: ./packages/api-client/coverage/lcov.info
20 changes: 8 additions & 12 deletions .github/workflows/visualizations.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,10 @@ jobs:

steps:
- name: Checkout repo
uses: actions/checkout@v2
uses: actions/checkout@v4

- name: Use Node ${{ matrix.node }}
uses: actions/setup-node@v1
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node }}

Expand All @@ -49,10 +49,10 @@ jobs:

steps:
- name: Checkout repo
uses: actions/checkout@v2
uses: actions/checkout@v4

- name: Use Node ${{ matrix.node }}
uses: actions/setup-node@v1
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node }}

Expand All @@ -65,22 +65,18 @@ jobs:
chromatic-deployment:
if: github.event.pull_request.draft == false || github.ref_name == 'main'
runs-on: ubuntu-latest
strategy:
matrix:
node: ["18.x", "20.x"]

needs: [test, lint]

steps:
- name: Checkout repo
uses: actions/checkout@v2
uses: actions/checkout@v4
with:
fetch-depth: 0

- name: Use Node ${{ matrix.node }}
uses: actions/setup-node@v1
- name: Use Node 20
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node }}
node-version: '20.x'

- name: Build
run: npm run build-ci
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ emptyState.args = {
export const RtlDirection = Template.bind({});
RtlDirection.parameters = {
direction: 'rtl',
disableSnapshot: true,
chromatic: { disableSnapshot: true },
};
RtlDirection.args = {
data,
Expand Down

1 comment on commit 2f2b663

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coverage for this commit

94.64%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   index.ts100%100%100%100%
src/client
   error.ts100%100%100%100%
   index.ts84.14%74.03%100%95.31%102–103, 124, 13, 146, 148, 148–149, 15, 15, 151, 162, 169, 169, 17, 17, 171, 176, 179, 182, 184, 52, 82
   types.ts100%100%100%100%
src/odsql
   clauses.ts82.61%71.43%80%90.91%14, 32, 42
   index.ts92.05%83.72%95.74%94.19%111, 146, 25, 28, 56–57, 57, 57–58, 68, 78–79

Please sign in to comment.