Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/update actions #255

Merged
merged 8 commits into from
Jul 12, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 7 additions & 12 deletions .github/workflows/api-client.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,22 +8,17 @@ on:
- main
jobs:
build:
name: Get api client test coverage on node ${{ matrix.node }} and ${{ matrix.os }}

runs-on: ${{ matrix.os }}
strategy:
matrix:
node: ["18.x", "20.x"]
os: [ubuntu-latest]
name: Get api client test coverage
runs-on: ubuntu-latest

steps:
- name: Checkout repo
uses: actions/checkout@v2
uses: actions/checkout@v4

- name: Use Node ${{ matrix.node }}
uses: actions/setup-node@v1
- name: Use Node 20
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node }}
node-version: '20.x'

- name: Install
run: npm ci
Expand All @@ -38,7 +33,7 @@ jobs:
working-directory: ./packages/api-client

- name: Comment
uses: romeovs/lcov-reporter-action@v0.2.19
uses: romeovs/lcov-reporter-action@v0.4.0
with:
github-token: ${{ secrets.GITHUB_TOKEN }}
lcov-file: ./packages/api-client/coverage/lcov.info
20 changes: 8 additions & 12 deletions .github/workflows/visualizations.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,10 @@ jobs:

steps:
- name: Checkout repo
uses: actions/checkout@v2
uses: actions/checkout@v4

- name: Use Node ${{ matrix.node }}
uses: actions/setup-node@v1
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node }}

Expand All @@ -49,10 +49,10 @@ jobs:

steps:
- name: Checkout repo
uses: actions/checkout@v2
uses: actions/checkout@v4

- name: Use Node ${{ matrix.node }}
uses: actions/setup-node@v1
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node }}

Expand All @@ -65,22 +65,18 @@ jobs:
chromatic-deployment:
if: github.event.pull_request.draft == false || github.ref_name == 'main'
runs-on: ubuntu-latest
strategy:
matrix:
node: ["18.x", "20.x"]

needs: [test, lint]

steps:
- name: Checkout repo
uses: actions/checkout@v2
uses: actions/checkout@v4
with:
fetch-depth: 0

- name: Use Node ${{ matrix.node }}
uses: actions/setup-node@v1
- name: Use Node 20
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node }}
node-version: '20.x'

- name: Build
run: npm run build-ci
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ emptyState.args = {
export const RtlDirection = Template.bind({});
RtlDirection.parameters = {
direction: 'rtl',
disableSnapshot: true,
chromatic: { disableSnapshot: true },
};
RtlDirection.args = {
data,
Expand Down