Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove release announcement from non nf-core pipelines #3024

Closed
wants to merge 219 commits into from
Closed

Remove release announcement from non nf-core pipelines #3024

wants to merge 219 commits into from

Conversation

LaurenceKuhl
Copy link
Contributor

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

This solves issue #2839

ewels and others added 30 commits August 21, 2023 00:15
@ewels
WIP: First stab at writing some Textual
513de95
@ewels
Refactor: Break into multiple files
0e8204e
@ewels
Remove unusued imports
e37d2e5
@mirpedrol
show error message when pressing enter
ee12eb5
@mirpedrol
show failure messages when button is pressed
dd18bcc
@mirpedrol
add usegenomicdata screen (TODO on_button_pressed)
486f180
@mirpedrol
add custom pipeline switch table to select pipeline features
5b8cfd5
@mirpedrol
create new widget PipelineFeature to display feature buttons and help…
0a40dab 
… text
@mirpedrol
add more custom features
39b9e3c
@mirpedrol
add template features to skip to TEMPLATE_CONFIG
25c9fa1
@mirpedrol
animate help box
610cbd9
@mirpedrol
add type_nfcore screen and use PipelineCreate to create a pipeline
6677144
@mirpedrol
modify PipelineCreate to accept a template dictionary
8bac0be
@mirpedrol
start modifying nf-core create command to use TUI and not CLI
43db7f6
@mirpedrol
small bug fixes and add a deprecation message for nf-core create command
99f426a
@mirpedrol
create command fails if one but not all arguments are provided
09bd5db
@mirpedrol
ask if launching TUI when using deprecated nf-core create command
9f121f7
@mirpedrol
add final_details screen for version and force
0c77029
@mirpedrol
add nfcorepipeline grid with features to select
bf9a541
@mirpedrol
first ask if the pipeline will be nf-core or custom before basicdetails
fec5e3e
@mirpedrol
use kwargs
0ef16b5
@mirpedrol
remove inexisten variable version from send-tweet github workflow
238767f
@mirpedrol
fix typo in gh_badges jinja variable to github_badges
7b4a342
@mirpedrol
bump version of nf-test snap files
b3fa25e
@mirpedrol
update changelog
6ff69b2
@mirpedrol
add outdir textinput and update config
17ba971
@mirpedrol
refactor jinja template 'branded' to 'is_nfcore'
0c64de8
@mirpedrol
refactor params_dict to jinja_params and use that instead of the config
7720117
@mirpedrol
refactor function obtain_jinja_params_dict
cb62be3
@mirpedrol
run create command from the App, mv nf_core/create.py to nf_core/pipe…
da1c68f 
…lines/create/create.py
mirpedrol and others added 26 commits May 29, 2024 15:35
@mirpedrol
use pydantic validation context on module initialization. use global …
60b79b1 
…variable for pipeline type
@nf-core-bot
[automated] Update CHANGELOG.md
0186535
@mirpedrol
use union for typing
6275553
@mirpedrol
Merge pull request nf-core#2978 from mirpedrol/conditional-linting
26fb9e5 
Template: Lint pipelines with the nf-core template version and post comment if it is outdated
@mirpedrol
use NFCORE_PIPELINE as a boolean instead of a PIPELINE_TYPE string
2b724e0
@mirpedrol
Merge pull request nf-core#3008 from mirpedrol/pipeline-name-validation
d7ce41b 
Create: allow more special characters on the pipeline name for non-nf-core pipelines
@ewels
README - absolute image paths
02017aa 
Make the logo render on PyPI
@nf-core-bot
[automated] Update CHANGELOG.md
0892642
@ewels
Conda module linting: Include package name in log file
b96f56b 
Tried to do this with GitHub Copilot Workspaces but it failed 😅 

As I was looking at the code anyway I could see the fix so figured I would put it manually.

Closes nf-core#3009

Untested, done in web browser only.
@renovate
Update pre-commit hook astral-sh/ruff-pre-commit to v0.4.7
93acb91
@nf-core-bot
[automated] Update CHANGELOG.md
d4a9183
@mashehu
Merge pull request nf-core#3015 from nf-core/renovate/astral-sh-ruff-…
6d7e00d 
…pre-commit-0.x

Update pre-commit hook astral-sh/ruff-pre-commit to v0.4.7
@mirpedrol
Merge branch 'dev' into readme-absolute-images
e9c596d
@mirpedrol
Merge pull request nf-core#3013 from nf-core/readme-absolute-images
fd34107 
README - absolute image paths
@mirpedrol
update changelog
847a376
@mirpedrol
Merge pull request nf-core#3014 from nf-core/lint-conda-name-in-log
14f0da4 
Conda module linting: Include package name in log file
@renovate
Update pre-commit hook astral-sh/ruff-pre-commit to v0.4.8
005972e
@nf-core-bot
[automated] Update CHANGELOG.md
ee5a22b
@mashehu
Merge pull request nf-core#3017 from nf-core/renovate/astral-sh-ruff-…
feb5685 
…pre-commit-0.x
@renovate
Update python:3.12-slim Docker digest to e3ae8cf
8ee2040
@nf-core-bot @renovate
[automated] Update CHANGELOG.md
a63a653
@renovate
Update dawidd6/action-download-artifact action to v6
05f60b4
@renovate
Update python:3.12-slim Docker digest to 2fba8e7
90f7e34
@nf-core-bot @renovate
[automated] Update CHANGELOG.md
6f444c9
@renovate
Update pre-commit hook astral-sh/ruff-pre-commit to v0.4.9
a15a6f0
@mashehu
Merge pull request nf-core#3022 from nf-core/renovate/astral-sh-ruff-…
4157a20 
…pre-commit-0.x
@github-actions GitHub Actions
Copy link
Contributor

This PR is against the master branch ❌

  • Do not close this PR
  • Click Edit and change the base to dev
  • This CI test will remain failed until you push a new commit

Hi @LaurenceKuhl,

It looks like this pull-request is has been made against the LaurenceKuhl/tools master branch.
The master branch on nf-core repositories should always contain code from the latest release.
Because of this, PRs to master are only allowed if they come from the LaurenceKuhl/tools dev branch.

You do not need to close this PR, you can change the target branch to dev by clicking the "Edit" button at the top of this page.
Note that even after this, the test will continue to show as failing until you push a new commit.

Thanks again for your contribution!

@LaurenceKuhl LaurenceKuhl deleted the dev_upstream branch June 17, 2024 14:29
@LaurenceKuhl LaurenceKuhl restored the dev_upstream branch June 17, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.