Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new nf-test features #6286

Open
wants to merge 19 commits into
base: master
Choose a base branch
from
Open

Use new nf-test features #6286

wants to merge 19 commits into from

Conversation

edmundmiller
Copy link
Contributor

  • ci: Attempt to split everything out
  • ci: Add changed since, sharding, and ci
  • ci: Add filter to try to get jobs split up
  • ci: Switch to only-changed
  • ci: See if follow-dependencies works without "related-tests"

@edmundmiller
Copy link
Contributor Author

edmundmiller commented Aug 26, 2024

We do have adamrtalbot/detect-nf-test-changes as a fallback option?

That's what we're currently using, so I don't really see it as a fallback 😆 It works fine, I think the sharding can work better and waste less resources spinning up a runner for each test instead of spinning up a consistent amount per PR.

That would close #391 as well, and might encourage people to make smaller PRs if we're only giving them 9 CI runners per PR anyway.

@edmundmiller
Copy link
Contributor Author

Current things blocking this is nf-core/tools#3140 or we can give up and keep the paths-filter step for that

@edmundmiller
Copy link
Contributor Author

Removed the need to use nf-core lint with pre-commit, as that wasn't truely blocking this from getting merged.

We can make a follow up issue to run every linting step through pre-commit.

@maxulysse
Copy link
Member

Looking good, there's still some leftover comments in the nf-test yml, but I like it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Caused by: java.nio.channels.OverlappingFileLockException
2 participants