Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass a list of modules/subworkflows(files) to nf-core modules lint #3140

Open
edmundmiller opened this issue Aug 26, 2024 · 0 comments
Open

Comments

@edmundmiller
Copy link
Contributor

Description of feature

I was working on nf-core/modules#6286 last week.

I really wanted to avoid using path-filter and having the whole separate step logic for the linting.

I think we could offload the changed files to pre-commit, and create pre-commit hooks for nf-core/tools. I think it would be pretty slick for pipelines as well(I know I don't run nf-core lint often enough personally)

The only issue I had was the way pre-commit passes files. It will pass nf-core modules lint modules/nf-core/bowtie/align/main.nf modules/nf-core/bowtie/build/main.nf modules/nf-core/fastqc/main.nf ... which currently doesn't work.

@nf-core nf-core deleted a comment Aug 26, 2024
edmundmiller pushed a commit to nf-core/modules that referenced this issue Sep 18, 2024
edmundmiller pushed a commit to nf-core/modules that referenced this issue Sep 18, 2024
edmundmiller pushed a commit to nf-core/modules that referenced this issue Sep 18, 2024
edmundmiller pushed a commit to nf-core/modules that referenced this issue Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant