phylogenetic: Use inline root sequence #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on feedback from @jameshadfield in #56 (comment) Looking at the existing dataset files on S3, the 5 KiB root-sequence.json is pretty negligible when the main Auspice JSON is only 163 KiB. Nextstrain datasets are limited by the 500MB memory cap in Chrome,¹ so we'd be fine adding the root sequence inline. ¹ nextstrain/auspice#1622
|
Merging since the CI run's outputs include |
|
Manually deleted cache and triggered a re-run of the ingest-to-phylo workflow. Once complete
|
jameshadfield
added a commit
to nextstrain/nextstrain.org
that referenced
this pull request
Apr 19, 2024
nextstrain/zika#57 removed the zika root sequence sidecar (as it's inlined in the main JSON). Note that the staging/zika dataset still has the root sequence sidecar and we assert its existence in tests here!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on feedback from @jameshadfield in
#56 (comment)
Looking at the existing dataset files on S3,
the 5 KiB root-sequence.json is pretty negligible when the main Auspice JSON is only 163 KiB. Nextstrain datasets are limited by the 500MB memory cap in Chrome,¹ so we'd be fine adding the root sequence inline.
¹ nextstrain/auspice#1622
Checklist