Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tests now that zika root sequence is inline #831

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

jameshadfield
Copy link
Member

nextstrain/zika#57 removed the zika root sequence sidecar (as it's inlined in the main JSON). Note that the staging/zika dataset still has the root sequence sidecar and we assert its existence in tests here!

nextstrain/zika#57 removed the zika root
sequence sidecar (as it's inlined in the main JSON). Note that the
staging/zika dataset still has the root sequence sidecar and we assert
its existence in tests here!
@nextstrain-bot nextstrain-bot temporarily deployed to nextstrain-s-james-fix--jent5r April 19, 2024 00:34 Inactive
Copy link
Contributor

@joverlee521 joverlee521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, thanks for fixing this! I did not realize we tested the existence of sidecar files here!

@jameshadfield jameshadfield merged commit 4351b25 into master Apr 19, 2024
4 checks passed
@jameshadfield jameshadfield deleted the james/fix-failing-zika-test branch April 19, 2024 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants