ingest: Update geolocation_rules #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add rules to switch the division and location for geolocations that do not follow the expected GenBank geolocation format. Following this change, the divisions are back down to 50 values which are the expected US states. Resolves <#134>
|
|
||
| # Switch location and divisions | ||
| North America/USA/Barnstable/MA North America/USA/MA/Barnstable | ||
| North America/USA/Barrington/RI North America/USA/RI/Barrington |
There was a problem hiding this comment.
Should "RI" be "Rhode Island", or will line 15 kick in and achieve this for us? (Using this as an example, but it applies to lines 21 to 81)
There was a problem hiding this comment.
Answer: "RI" is not in the curated metadata, so yes the rule on line 15 must be being used to convert this to "Rhode Island"
jameshadfield
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Add rules to switch the division and location for geolocations that do not follow the expected GenBank geolocation format.
Following this change, the divisions are back down to 50 values which are the expected US states.
Related issue(s)
Resolves #134
Also fixes #131 by lowering the division count to be less than the color schemes.
Checklist