Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[genome builds] Fix coloring assignment for division #132

Closed
wants to merge 2 commits into from

Conversation

jameshadfield
Copy link
Member

Closes #131

We should revisit this once we've managed to spend some time improving the metadata side of things

Doesn't fix the underlying bug but restores the intention of the try/
except block
@jameshadfield
Copy link
Member Author

Given #133 I wonder if we should hold off on merging this for a day while we debug that one?

@jameshadfield
Copy link
Member Author

jameshadfield commented Feb 21, 2025

Closing this PR - the original commit has been merged via #136 and the number of divisions in the metadata has been reduced by #135 which resolves #131 in a better way than this PR

@jameshadfield jameshadfield deleted the james/fix-division branch February 21, 2025 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automated Ingest to phylogenetic workflow failed during assign-colors
1 participant