Drop Python 3.8 support and add Python 3.12 #302
Conversation
chadell
requested review from
glennmatthews,
pke11y,
scetron and
jvanderaa
as code owners
poetry.lock
Outdated
| @@ -1,4 +1,4 @@ | |||
| # This file is automatically @generated by Poetry 1.8.3 and should not be changed by hand. | |||
| # This file is automatically @generated by Poetry 1.6.1 and should not be changed by hand. | |||
There was a problem hiding this comment.
What necessitated regenerating/updating the poetry.lock with new dependency versions?
There was a problem hiding this comment.
There was a problem hiding this comment.
Not a bad thing to move poetry versions forward. Any harm that I'm not aware of on this?
There was a problem hiding this comment.
Looks like this is moving the poetry version itself backwards, which seems wrong. Just updating the min Python version shouldn't require re-locking all other dependencies (poetry lock --no-update would suffice); I'm not opposed to it in principle but it might be better done as a separate PR.
There was a problem hiding this comment.
ah, I see what you mean, I shouldn't move back
There was a problem hiding this comment.
I have regenerated with the latest poetry. I agree that a separate PR could have been better, but I would keep it together to simplify it for now.
No description provided.