-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Pccw parser #301
Merged
Merged
Add Pccw parser #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snitass
requested review from
chadell,
glennmatthews,
pke11y,
scetron and
jvanderaa
as code owners
January 2, 2025 21:46
Open
chadell
reviewed
Jan 3, 2025
chadell
reviewed
Jan 3, 2025
chadell
reviewed
Jan 3, 2025
chadell
reviewed
Jan 3, 2025
In the CI, there is an error due to Python 3.8 support:
-> The syntax tuple[datetime, datetime] is subscriptable typing, which is supported only in Python 3.9+. |
chadell
approved these changes
Jan 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, many thanks @snitass !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code implements parsers for PCCW (a telecommunications company) circuit maintenance email notifications. It consists of two main classes:
HtmlParserPccw: Parses the HTML content of maintenance emails to extract:
SubjectParserPccw: Parses the email subject line to extract:
The parsers use regular expressions and string manipulation to extract relevant information from the email content. The datetime values are handled in a specific format ("%d/%m/%Y %H:%M:%S") and converted to timestamps.