Skip to content

Commit

Permalink
Drop Python 3.8 support and add Python 3.12 (#302)
Browse files Browse the repository at this point in the history
* Drop Python 3.8 support and add Python 3.12

* Ignore mypy check in a compatibility workaround

* poetry lock with poetry 1.8.5
  • Loading branch information
chadell authored Jan 3, 2025
1 parent 60319aa commit 5a43070
Show file tree
Hide file tree
Showing 5 changed files with 908 additions and 829 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ jobs:
strategy:
fail-fast: true
matrix:
python-version: ["3.8", "3.9", "3.10", "3.11"]
python-version: ["3.9", "3.10", "3.11", "3.12"]
pydantic: ["2.x"]
include:
- python-version: "3.11"
Expand Down
2 changes: 1 addition & 1 deletion circuit_maintenance_parser/parser.py
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ class Parser(BaseModel):
def get_data_types(cls) -> List[str]:
"""Return the expected data type."""
try:
return cls._data_types.get_default()
return cls._data_types.get_default() # type: ignore[attr-defined]
except AttributeError:
# TODO: This exception handling is required for Pydantic 1.x compatibility. To be removed when the dependency is deprecated.
return cls()._data_types
Expand Down
Loading

0 comments on commit 5a43070

Please sign in to comment.