-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CPP Best Practices #2691
CPP Best Practices #2691
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2691 +/- ##
==========================================
- Coverage 50.74% 0.00% -50.73%
==========================================
Files 392 159 -233
Lines 32553 20672 -11881
Branches 0 2808 +2808
==========================================
- Hits 16517 0 -16517
- Misses 16036 20672 +4636 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR doesn't build and doesn't address the mentioned issues. Why should the install directory be changed? Closing this PR.
@BhavdeepSinghNijhawan you've opened a bunch of PRs that looked like you were not sure what you're actually doing. Please follow these guidelines for contributing to moveit. Furthermore, please
- Make sure your code is building locally before submitting a PR
- Add a proper verbose description of your changes to the PR.
- If you're unsure or need help, start with trying to fix a single issue with one PR and ask questions in that PR so we can help you. Opening multiple not working PRs is considered rude.
Fixes #852
Fixes #1928
Checklist