Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CPP Best Practices #2691

Closed
wants to merge 18 commits into from
Closed

CPP Best Practices #2691

wants to merge 18 commits into from

Conversation

BhavdeepSinghNijhawan
Copy link

@BhavdeepSinghNijhawan BhavdeepSinghNijhawan commented Feb 16, 2024

Fixes #852
Fixes #1928

Checklist

  • Extend the tutorials / documentation reference

@BhavdeepSinghNijhawan BhavdeepSinghNijhawan changed the title Update compare_collision_speed_checking_fcl_bullet.cpp CPP Best Practices Feb 29, 2024
Copy link

codecov bot commented Mar 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (d962501) to head (56f90f6).
Report is 15 commits behind head on main.

❗ Current head 56f90f6 differs from pull request most recent head 936ac2a. Consider uploading reports for the commit 936ac2a to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #2691       +/-   ##
==========================================
- Coverage   50.74%   0.00%   -50.73%     
==========================================
  Files         392     159      -233     
  Lines       32553   20672    -11881     
  Branches        0    2808     +2808     
==========================================
- Hits        16517       0    -16517     
- Misses      16036   20672     +4636     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@sjahr sjahr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR doesn't build and doesn't address the mentioned issues. Why should the install directory be changed? Closing this PR.
@BhavdeepSinghNijhawan you've opened a bunch of PRs that looked like you were not sure what you're actually doing. Please follow these guidelines for contributing to moveit. Furthermore, please

  • Make sure your code is building locally before submitting a PR
  • Add a proper verbose description of your changes to the PR.
  • If you're unsure or need help, start with trying to fix a single issue with one PR and ask questions in that PR so we can help you. Opening multiple not working PRs is considered rude.

@sjahr sjahr closed this Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix overriding binary install Standardize comment style
2 participants