-
Notifications
You must be signed in to change notification settings - Fork 1.4k
MNT: Migrate to ipyvtklink #9341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Related to pyvista/pyvista#1257 |
There might be a way to fail sooner if for example PyVista throws ( |
Finally, I'll remind that although
|
A simple way to address this is to bump the requirements to |
Probably same treatment for |
|
This should be updated after #8741 is merged because |
@GuillaumeFavelier can you rebase or merge with |
Done in c141be4 |
We also might have to deal with:
https://github.com/mne-tools/mne-python/runs/2545597094#step:13:4933 @larsoner should I just update
|
I am fixing these in #9386 |
Good to go from your end @GuillaumeFavelier ? If so I'll merge once CIs come back happy other than pip-pre, and I'll double check that those just fail non-viz tests |
It's ready for me. I'll stay on the lookout for future adjustements if necessary. |
Starting from
0.30.0
,pyvista
usesipyvtklink
instead ofipyvtk_simple
.In
server_environment.yml
,ipyvtk_simple
is still installed so I expect the CIs to come back green with 71792d6 but after the release, it will fail becauseshow()
will return a static image instead of the expectedViewer
widget.It's an item of #8704