-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Reading events info from ceo file #9381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This function may cannot read event info from .cdt.ceo file. Here is the issue about the fix. mne-tools#9380
Hello! 👋 Thanks for opening your first pull request here! ❤️ We will try to get back to you soon. 🚴🏽♂️ |
@dddd1007 I've pushed a commit here that I think will fix your problem. Can you |
@drammock, I pulled this commit and tested it. Thanks for your fixation! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't even notice that, oops. |
Changed the base branch and closed-reopened to restart PRs. But we have a bunch of PyVista-related errors so maybe we should fix those first, then do another restart here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merge when CIs green.
🎉 Congrats on merging your first pull request! 🥳 Looking forward to seeing more from you in the future! 💪 |
Thanks @dddd1007 ! |
Reference issue
Fixes #9380
What does this implement/fix?
The read_raw_curry() cannot read the event file from .ceo file. So I try to make the function recognize .ceo files, a type of event file generated by Curry.