MNT: Migrate to ipyvtklink (#9341)

* Update backend

* Bump requirements

* Bump requirements

* Use zipball

* Fix

Author: GuillaumeFavelier

README.rst

@@ -104,8 +104,8 @@ For full functionality, some functions require:
 - CuPy >= 6.0.0 (for NVIDIA CUDA acceleration)
 - DIPY >= 1.0.0
 - Imageio >= 2.6.1
-- PyVista >= 0.24
-- pyvistaqt >= 0.2.0
+- PyVista >= 0.30
+- pyvistaqt >= 0.3.0
 - mffpy >= 0.5.7
 
 Contributing to MNE-Python

environment.yml

@@ -23,8 +23,7 @@ dependencies:
 - spyder-kernels>=1.10.0
 - imageio-ffmpeg>=0.4.1
 - vtk>=9.0.1
-- pyvista>=0.24
-- pyvistaqt>=0.2.0
+- pyvista>=0.30
 - qdarkstyle
 - darkdetect
 - mayavi
@@ -38,4 +37,5 @@ dependencies:
 - mffpy>=0.5.7
 - ipywidgets
 - pip:
-  - ipyvtk-simple
+  - ipyvtklink
+  - https://api.github.com/repos/pyvista/pyvistaqt/zipball/8eb40405b31ef815527a2620bc395cb9c5548377

mne/viz/_brain/_brain.py

@@ -1706,12 +1706,7 @@ def _clear_callbacks(self):
         self.callbacks.clear()
         # Remove the default key binding
         if getattr(self, "iren", None) is not None:
-            try:
-                # pyvista<0.30.0
-                self.plotter._key_press_event_callbacks.clear()
-            except AttributeError:
-                # pyvista>=0.30.0
-                self.plotter.iren.clear_key_event_callbacks()
+            self.plotter.iren.clear_key_event_callbacks()
 
     def _clear_widgets(self):
         if not hasattr(self, 'widgets'):

mne/viz/backends/_pyvista.py

@@ -670,12 +670,7 @@ def _update_picking_callback(self,
                                  on_button_press,
                                  on_button_release,
                                  on_pick):
-        try:
-            # pyvista<0.30.0
-            add_obs = self.plotter.iren.AddObserver
-        except AttributeError:
-            # pyvista>=0.30.0
-            add_obs = self.plotter.iren.add_observer
+        add_obs = self.plotter.iren.add_observer
         add_obs(vtk.vtkCommand.RenderEvent, on_mouse_move)
         add_obs(vtk.vtkCommand.LeftButtonPressEvent, on_button_press)
         add_obs(vtk.vtkCommand.EndInteractionEvent, on_button_release)

mne/viz/conftest.py

@@ -57,7 +57,7 @@ def _nbclient():
         from jupyter_client import AsyncKernelManager
         from nbclient import NotebookClient
         from ipywidgets import Button  # noqa
-        import ipyvtk_simple  # noqa
+        import ipyvtklink  # noqa
     except Exception as exc:
         return pytest.skip(f'Skipping Notebook test: {exc}')
     km = AsyncKernelManager(config=None)

mne/viz/tests/test_3d.py

@@ -728,12 +728,7 @@ def test_plot_sensors_connectivity(renderer):
 
     fig = plot_sensors_connectivity(info=info, con=con, picks=picks)
     if renderer._get_3d_backend() == 'pyvista':
-        try:
-            # pyvista<0.30.0
-            title = fig.plotter.scalar_bar.GetTitle()
-        except AttributeError:
-            # pyvista>=0.30.0
-            title = list(fig.plotter.scalar_bars.values())[0].GetTitle()
+        title = list(fig.plotter.scalar_bars.values())[0].GetTitle()
     else:
         assert renderer._get_3d_backend() == 'mayavi'
         # the last thing we add is the Tube, so we need to go

requirements.txt

@@ -27,9 +27,9 @@ nilearn
 xlrd
 imageio>=2.6.1
 imageio-ffmpeg>=0.4.1
-pyvista>=0.24
-pyvistaqt>=0.2.0
+pyvista>=0.30
+https://api.github.com/repos/pyvista/pyvistaqt/zipball/8eb40405b31ef815527a2620bc395cb9c5548377
 tqdm
 mffpy>=0.5.7
 ipywidgets
-ipyvtk-simple
+ipyvtklink

server_environment.yml

@@ -12,7 +12,7 @@ dependencies:
 - scipy
 - numpy
 - matplotlib-base
-- pyvista
+- pyvista>=0.30
 - nilearn
 - nibabel
 - nbformat <5.1  # XXX remove pinning once https://github.com/jupyter/nbformat/issues/206 has been fixed
@@ -23,5 +23,5 @@ dependencies:
   - jupyter
   - ipympl
   - ipywidgets
-  - ipyvtk_simple
+  - ipyvtklink
   - jupyter_client!=6.1.5