Skip to content

Onboard to cibuildwheel and improve macOS build #8754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

snnn
Copy link
Member

@snnn snnn commented Aug 17, 2021

Description:

This PR adds python packages for PyPy LInux x86_64, CPython 3.6-3.9 macOS ARM, CPython 3.6-3.9 CentOS 8.

Add Linux/Mac ARM64 binaries to Microsoft.ML.OnnxRuntime nuget package.

cibuildwheel is a tool to help build python packages across Mac, Linux, Windows, on multiple versions of Python.

Add the ability of cross compiling for another CPU ARCH on macOS without building protoc separately. For example, build ORT arm64 on a x86_64 macOS or vice versa. And add the ability to generate universal2 binaries for macOS. It can be set through CMAKE_OSX_ARCHITECTURES.

And remove onnxruntime_CROSS_COMPILING cmake option because it is very confusing. When you an iOS app on x86_64, is it considered as cross compiling or not? No, it's not. But building for Windows ARM is, and building for macOS ARM is not. I believe it will confuse all the people. Therefore, we should not expose such a configuration.

And remove Linux-iOS cross-compiling based on the TODO comment in build.py. "The cross compiling on Linux is not officially supported by Apple and is already broken with the latest codebase, so it should be removed"

Motivation and Context

  • Why is this change required? What problem does it solve?
  • If it fixes an open issue, please link to the issue here.

#8420 #6633 #6573

@snnn snnn requested a review from a team as a code owner August 17, 2021 02:07
@snnn snnn force-pushed the snnn/cibuildwheel branch 4 times, most recently from 6d61a9c to d654002 Compare August 18, 2021 07:09
@snnn snnn marked this pull request as draft August 18, 2021 08:12
@snnn snnn force-pushed the snnn/cibuildwheel branch 2 times, most recently from 617f0f5 to 2f12704 Compare August 18, 2021 20:51
@snnn
Copy link
Member Author

snnn commented Aug 18, 2021

image

@snnn snnn force-pushed the snnn/cibuildwheel branch from c2ce31b to 168103a Compare August 19, 2021 00:26
@snnn snnn changed the title Onboard to cibuildwheel Onboard to cibuildwheel and improve macOS build Aug 19, 2021
@snnn snnn force-pushed the snnn/cibuildwheel branch 7 times, most recently from f2509d4 to 0351001 Compare August 21, 2021 01:08
@snnn snnn force-pushed the snnn/cibuildwheel branch from 0351001 to 085e9c1 Compare August 21, 2021 08:12
@snnn snnn force-pushed the snnn/cibuildwheel branch 3 times, most recently from 223e0f1 to b11b0f7 Compare August 24, 2021 01:07
@snnn snnn force-pushed the snnn/cibuildwheel branch from 6898eb3 to 18491b8 Compare August 24, 2021 23:23
@snnn snnn marked this pull request as ready for review August 24, 2021 23:24
@snnn snnn requested review from jywu-msft and chilo-ms August 25, 2021 03:58
@snnn
Copy link
Member Author

snnn commented Aug 30, 2021

I'm splitting it to smaller pieces.

@snnn snnn force-pushed the snnn/cibuildwheel branch 4 times, most recently from 9763508 to 1693fda Compare September 2, 2021 22:41
@snnn snnn force-pushed the snnn/cibuildwheel branch 4 times, most recently from 0df46e0 to 2a482b1 Compare September 7, 2021 18:17
@snnn snnn marked this pull request as ready for review September 7, 2021 18:18
@snnn snnn force-pushed the snnn/cibuildwheel branch 4 times, most recently from c798757 to 78a2591 Compare September 10, 2021 07:14
@snnn snnn force-pushed the snnn/cibuildwheel branch from 78a2591 to 6f40192 Compare September 15, 2021 20:25
@snnn snnn force-pushed the snnn/cibuildwheel branch from 110546f to 0bb18e3 Compare September 28, 2021 18:52
@snnn snnn force-pushed the snnn/cibuildwheel branch from 0bb18e3 to 457123d Compare October 26, 2021 04:30
@snnn snnn force-pushed the snnn/cibuildwheel branch from 14bce8f to df02205 Compare November 18, 2021 00:24
@mbalesni
Copy link

@chilo-ms it seems you are the last reviewer left to merge this. Is there anything in the way?

@stale
Copy link

stale bot commented Apr 16, 2022

This issue has been automatically marked as stale due to inactivity and will be closed in 7 days if no further activity occurs. If further support is needed, please provide an update and/or more details.

@stale stale bot added the stale issues that have not been addressed in a while; categorized by a bot label Apr 16, 2022
@snnn snnn closed this Oct 31, 2022
@snnn snnn deleted the snnn/cibuildwheel branch March 29, 2023 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale issues that have not been addressed in a while; categorized by a bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants