-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Onboard to cibuildwheel and improve macOS build #8754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6d61a9c
to
d654002
Compare
617f0f5
to
2f12704
Compare
c2ce31b
to
168103a
Compare
f2509d4
to
0351001
Compare
0351001
to
085e9c1
Compare
223e0f1
to
b11b0f7
Compare
6898eb3
to
18491b8
Compare
I'm splitting it to smaller pieces. |
9763508
to
1693fda
Compare
0df46e0
to
2a482b1
Compare
c798757
to
78a2591
Compare
78a2591
to
6f40192
Compare
110546f
to
0bb18e3
Compare
0bb18e3
to
457123d
Compare
14bce8f
to
df02205
Compare
df02205
to
83543f7
Compare
@chilo-ms it seems you are the last reviewer left to merge this. Is there anything in the way? |
This issue has been automatically marked as stale due to inactivity and will be closed in 7 days if no further activity occurs. If further support is needed, please provide an update and/or more details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds python packages for PyPy LInux x86_64, CPython 3.6-3.9 macOS ARM, CPython 3.6-3.9 CentOS 8.
Add Linux/Mac ARM64 binaries to Microsoft.ML.OnnxRuntime nuget package.
cibuildwheel is a tool to help build python packages across Mac, Linux, Windows, on multiple versions of Python.
Add the ability of cross compiling for another CPU ARCH on macOS without building protoc separately. For example, build ORT arm64 on a x86_64 macOS or vice versa. And add the ability to generate universal2 binaries for macOS. It can be set through CMAKE_OSX_ARCHITECTURES.
And remove
onnxruntime_CROSS_COMPILING
cmake option because it is very confusing. When you an iOS app on x86_64, is it considered as cross compiling or not? No, it's not. But building for Windows ARM is, and building for macOS ARM is not. I believe it will confuse all the people. Therefore, we should not expose such a configuration.And remove Linux-iOS cross-compiling based on the TODO comment in build.py. "The cross compiling on Linux is not officially supported by Apple and is already broken with the latest codebase, so it should be removed"
Motivation and Context
#8420 #6633 #6573