Move iOS package from framework to xcframework #8805
Conversation
| "OTHER_CPLUSPLUSFLAGS" => "-fvisibility=hidden -fvisibility-inlines-hidden", | ||
| } | ||
| spec.user_target_xcconfig = { | ||
| spec.xcconfig = { |
There was a problem hiding this comment.
Had to make this change, otherwise the pod lib lint will fail since we don't include arm64 ios-simulator yet, hopefully this can be removed after we enable the arm64 ios-simulator build #Resolved
There was a problem hiding this comment.
is there documentation for the xcconfig attribute? I didn't see it here https://guides.cocoapods.org/syntax/podspec.html
There was a problem hiding this comment.
I found this on stackoverflow, this is not in the official podspec syntax, we should be able to get rid of this soon
There was a problem hiding this comment.
This is no longer needed after the latest commits
| {'sysroot': 'iphoneos', 'arch': 'arm64'}, | ||
| {'sysroot': 'iphonesimulator', 'arch': 'x86_64'}, | ||
| ] | ||
| # We by default will build below 3 archs |
There was a problem hiding this comment.
Will remove in a later PR
| @@ -50,6 +52,8 @@ def main(): | |||
| # copy the necessary files to the staging directory | |||
| framework_dir = args.framework_dir.resolve() | |||
| shutil.copytree(framework_dir, staging_dir / framework_dir.name, dirs_exist_ok=True) | |||
| public_headers_dir = args.public_headers_dir.resolve() | |||
| shutil.copytree(public_headers_dir, staging_dir / public_headers_dir.name, dirs_exist_ok=True) | |||
| @@ -50,6 +52,8 @@ def main(): | |||
| # copy the necessary files to the staging directory | |||
| framework_dir = args.framework_dir.resolve() | |||
| shutil.copytree(framework_dir, staging_dir / framework_dir.name, dirs_exist_ok=True) | |||
| public_headers_dir = args.public_headers_dir.resolve() | |||
| shutil.copytree(public_headers_dir, staging_dir / public_headers_dir.name, dirs_exist_ok=True) | |||
| copy_repo_relative_to_dir(["LICENSE"], staging_dir) | |||
There was a problem hiding this comment.
Actually we don't need to copy in multiple steps, we can copy everything from the framework_out directly, since it contains everything we need here,
Can change in a later PR
Description: Move iOS package from framework to xcframework
Motivation and Context
https://aiinfra.visualstudio.com/Lotus/_build/results?buildId=170530&view=results, https://aiinfra.visualstudio.com/Lotus/_build/results?buildId=170897&view=results)arm64 ios simulator is not yet included in the build due to eigen build failure, pending changes from Onboard to cibuildwheel and improve macOS build #8754, take the downgrade eigen part of Onboard to cibuildwheel and improve macOS build #8754, enable build for arm64 ios-simulator