Nuget: splitting PDB files to a separated package #8903
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jywu-msft
reviewed
Aug 31, 2021
|
|
||
|
|
||
| # What does the names of our C API tarball/zip files looks like | ||
| # os: win, linux, osx |
There was a problem hiding this comment.
shouldn't our tarball and zip packages have -gpu suffix for name ? (not cuda/tensorrt which are internal intermediate packages?)
There was a problem hiding this comment.
Yes, this function consumes the internal intermediate packages and produce a nuget package from that. This comment was written before the TRT work.
|
I tested the gpu nuget from CI's aritifact |
jywu-msft
approved these changes
Sep 1, 2021
|
Thank you @chilo-ms ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The Microsoft.ML.OnnxRuntime nuget packages include libraries with full symbols. This makes it very bloated. So split the PDB files a separated symbol package.
This PR is split from #8754, which is too big.
Motivation and Context
Offer Nuget package without PDB #6113 Nuget PDB files should not be included in the nuget #2742 How to get rid of large native/onnxruntime.pdb #102