Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Author: Myron Rodrigues
Issue
Issue link (if present): #604
Issue description: Currently the NN detection output is not to scale with the input image,
I've also passed the
socket
parameter innn_wrapper.cpp
the default is correct but if supplied by user through constructor this might be incorrectly setChanges
ROS distro:
iron
List of changes:
<sensor>_nn
nodes that rescales the detection to its original input:i_desqueeze_output: false(default)
ImgDetectionConverter
indepthai-ros/depthai_ros_driver/include/depthai_ros_driver/dai_nodes/nn/detection.hpp
if parameter is set.Testing
Hardware used: OAK-D Pro Wide
Depthai library version:
2.28.0
Depthai ros version:
cf5d2aaee9117298ea1632c98ffd36a5d7d535ac
a commit behind ironVisuals from testing on RGB socket
camera.yaml
complete launch file: here
camera.launch.py
Not setting
nn.i_desqueeze_output
ie. default (false)Setting
nn.i_desqueeze_output: true
Visuals from testing on mono left socket
camera.launch.py
camera.yaml
Setting
left_nn.i_desqueeze_output: true