Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto-bump images in Create release workflow #361

Closed
3 tasks
Tracked by #359
grischperl opened this issue Dec 21, 2023 · 0 comments · Fixed by #472
Closed
3 tasks
Tracked by #359

auto-bump images in Create release workflow #361

grischperl opened this issue Dec 21, 2023 · 0 comments · Fixed by #472
Assignees

Comments

@grischperl
Copy link
Collaborator

grischperl commented Dec 21, 2023

Description

  • Automatically generate sec-scanners-config.yaml
    • em image
    • epp image
    • webhook image
  • Bump em image here
  • Github action or script automatically opens a PR which needs manual approval
  • Tests on the PR ensure that linting and unit tests for the release are green

hint: you could use this script
hint 2: btp-manager already has a similar setup for pr creation.

Acceptance

  • Automatically create PR to update the sec-scanners-config.yaml and em-image definition
  • Trigger linting and unit test on this PR
  • Further flow of the Github action only upon approval & merging of this PR

Possible follow-up ticket:

  • Images are taken from one single file, to make image bumping simple and straight-forward
  • bumping images in kustomize setup also bumps sec-scanners-config.yaml on main
@grischperl grischperl changed the title Generate Generate sec-scanners-config.yaml Dec 21, 2023
@friedrichwilken friedrichwilken changed the title Generate sec-scanners-config.yaml Bump release images Jan 4, 2024
@friedrichwilken friedrichwilken self-assigned this Jan 16, 2024
@friedrichwilken friedrichwilken changed the title Bump release images auto-bump images in Create release workflow Jan 16, 2024
@friedrichwilken friedrichwilken linked a pull request Jan 31, 2024 that will close this issue
@marcobebway marcobebway reopened this Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants