generated from kyma-project/template-repository
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump sec-scanners-config and kustomize file in create release workflow #472
Merged
kyma-bot
merged 19 commits into
kyma-project:main
from
friedrichwilken:bump-sec-scanners-config
Feb 14, 2024
Merged
Bump sec-scanners-config and kustomize file in create release workflow #472
kyma-bot
merged 19 commits into
kyma-project:main
from
friedrichwilken:bump-sec-scanners-config
Feb 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyma-bot
added
area/ci
Issues or PRs related to CI related topics
cla: yes
Indicates the PR's author has signed the CLA.
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
labels
Feb 8, 2024
friedrichwilken
changed the title
Bump sec scanners config
Bump sec-scanners-config and kustomize file on release
Feb 8, 2024
3 tasks
friedrichwilken
changed the title
Bump sec-scanners-config and kustomize file on release
Bump sec-scanners-config and kustomize file in create release workflow
Feb 8, 2024
marcobebway
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
add option to havedry run
releases, that are not published, to test the release workflow.publish release
step; releases are now getting published only manually.create release
bumpssec-scanner-config
andkusomize
file and creates a PR and waits for it to be merged.- adding comments
- move all scripts to
hack/ci
scripts/check_sec-scanners-config.sh
since it is no longer needed since we generatesec-scanners-config.yaml
now.Test
this was tested on this branch which is a 1:1 copy of the pr. Here is a successful release run (resulting in a draft release because of the set
dry-run
option). It produced and waited for this pr that bumped the afore mentioned files. Finaly, this is the resulting (unpublished) release with the changelog and all assets. Also: Release image in the registryRelated issue(s)
#361