Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pass-commit-ref-as-input #70

Merged
merged 1 commit into from
Feb 7, 2024
Merged

pass-commit-ref-as-input #70

merged 1 commit into from
Feb 7, 2024

Conversation

friedrichwilken
Copy link
Contributor

@friedrichwilken friedrichwilken commented Feb 7, 2024 •
edited
Loading

Description

Calling this workflow will cause the error:

The workflow is not valid. In .github/workflows/create-release.yml (Line: 39, Col: 11): Error from called workflow kyma-project/eventing-tools/.github/workflows/trigger-prow-build-job-reusable.yml@7113a71873561bf9387f647ae39d275eab5dbd7a (Line: 66, Col: 23): Unrecognized named-value: 'GITHUB_REF_NAME'. Located at position 1 within expression: GITHUB_REF_NAME

So let's pass the commit_ref from the caller workflow, where GITHUB_REF_NAME is available.
Related issue(s)
issue

@friedrichwilken friedrichwilken requested a review from a team as a code owner February 7, 2024 09:40
@kyma-bot kyma-bot added area/ci Issues or PRs related to CI related topics cla: yes Indicates the PR's author has signed the CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 7, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Feb 7, 2024
@kyma-bot kyma-bot merged commit b434a1f into kyma-project:main Feb 7, 2024
5 checks passed
@friedrichwilken friedrichwilken deleted the pass-commit-ref-as-input branch February 7, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcobebway marcobebway marcobebway approved these changes

@grischperl grischperl Awaiting requested review from grischperl grischperl is a code owner automatically assigned from kyma-project/eventing

Assignees

@marcobebway marcobebway

Labels
area/ci Issues or PRs related to CI related topics cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@friedrichwilken @marcobebway @kyma-bot