helm-chart: improve test coverage and fix image-cleaner bug #1417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
consideRatio
force-pushed
the
pr/test-creation-of-k8s-resources
branch
from
6aaaa9d
to
34cecf5
Compare
consideRatio
force-pushed
the
pr/test-creation-of-k8s-resources
branch
from
34cecf5
to
1c35ceb
Compare
consideRatio
force-pushed
the
pr/test-creation-of-k8s-resources
branch
from
1c35ceb
to
c42efb8
Compare
23 tasks
consideRatio
pushed a commit
to jupyterhub/helm-chart
that referenced
this pull request
Oct 10, 2021
jupyterhub/binderhub#1417 Merge pull request #1417 from consideRatio/pr/test-creation-of-k8s-resources
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1397 that is about having test coverage of our k8s resources and fixes a critical regression with #1391 resolved in 1.0.0-alpha.2.