helm-chart: fix inability to omit ingress.hosts, make it optional #1411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should allow our template to generate properly without forcing users to specify ingress.hosts as it is a viable configuration that has been requested as in z2jh already.
consideRatio
commented
Oct 7, 2021
| {{- range .Values.ingress.hosts }} | ||
| - host: {{ . }} | ||
| http: | ||
| {{- range $host := .Values.ingress.hosts | default (list "") }} |
There was a problem hiding this comment.
By providing a default list with a single element containing a blank string, this loop will always yeild one rule - and when it does the host field will not be set.
|
I just ran into an error assuming I could rely on this in #1417, I'll go for a merge on this instead of trying to workaround it in that PR. |
consideRatio
pushed a commit
to jupyterhub/helm-chart
that referenced
this pull request
Oct 10, 2021
jupyterhub/binderhub#1411 Merge pull request #1411 from consideRatio/pr/handle-no-host
23 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should allow our template to generate properly without forcing users
to specify ingress.hosts as it is a viable configuration that has been
requested as in z2jh already.
Related